StefanLobbenmeier / youtube-dl-gui

A cross-platform GUI for youtube-dl made in Electron and node.js
GNU Affero General Public License v3.0
1.3k stars 52 forks source link

Microsoft Defender prevents opening the application, because unknown applications present a risk #90

Open Floriiixn opened 8 months ago

Floriiixn commented 8 months ago

Is your question related to a problem? Please describe. A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the question you have. A clear and concise question about youtube-dl-gui.

Additional context Add any other context or screenshots about the question here.

Floriiixn commented 8 months ago

When i try to download its says it could harm my pc. I downloaded it anyways, so when i try to open, it gets blocked from Windows defender.

StefanLobbenmeier commented 8 months ago

I think last time the issue was that Microsoft defender did not like yt-dlp, but it seems now it is complaining about the whole application?

Can you add a screenshot of that Microsoft defender popup?

StefanLobbenmeier commented 8 months ago

Maybe people also had that issue in the original repo:

https://github.com/jely2002/youtube-dl-gui/issues?q=Malware

this one in particular: https://github.com/jely2002/youtube-dl-gui/issues/139

Floriiixn commented 8 months ago

1 2

StefanLobbenmeier commented 8 months ago

I see, to me that looks more like an overeager notification. There are not enough people using the app yet, so it is flagged to be cautious.

Not sure what I can do about that.

Floriiixn commented 8 months ago

So its nothing to worry about ?

StefanLobbenmeier commented 8 months ago

Yeah nothing to worry about. I can just repeat what @jely2002 said in the linked issue, I also would not put malware in this app.

Of course I am also just a stranger on the internet, but maybe the GitHub stars can reassure you that there are around 800 people trusting me.

Also feel free to download the source code, look around it and compile it yourself. The binaries in the releases tab are built by GitHub actions from the source code available here

StefanLobbenmeier commented 8 months ago

Not sure if it will help, but I will try uploading the latest version to microsoft for analysis and maybe that will make the warning go away: https://stackoverflow.com/a/66582477

StefanLobbenmeier commented 8 months ago

Submitted, I will update the issue again when they finish validating image

Update: automatic validation is already happy with it after 5 minutes, not sure when Final determination changes image

StefanLobbenmeier commented 8 months ago

Got another update last night:

Analyst comments: The warning you experienced indicates that submitted file(s) did not have dedicated determination in our system. We can confirm that the files submitted are now determined as clean and attempting to download or run the application should no longer show any warnings. Due to the complexity of our backend systems, it may take up to 12 hours for the determination to be fully reflected and for the SmartScreen warnings to stop. For further information related to Microsoft Defender SmartScreen please refer to: https://learn.microsoft.com/en-us/windows/security/operating-system-security/virus-and-threat-protection/microsoft-defender-smartscreen/ Click here for more information

Could you open it again and confirm the notification is gone now? Then I can close this for now

EricGuic commented 8 months ago

Hi, I get the same warning just now (see first screencapture). The button says "Do not execute". If I click on "Informations complémentaires " (=more info), I get another button allowing me to execute the setup.exe.

image

image

Then, the setup installs the dependencies (C++, ffmpeg, yt-dlp) and then it works :-)

image

StefanLobbenmeier commented 3 months ago

Also feel free to download the source code, look around it and compile it yourself. The binaries in the releases tab are built by GitHub actions from the source code available here

Just to add on this, in v3 I made sure to be as transparent as possible about the releases done through github actions. The checksum is printed during the build which is available to anyone who is logged it, e.g. here: https://github.com/StefanLobbenmeier/yt-dlp-compose/actions/runs/8636702660/job/23677216546. So this makes sure I cannot change out the binaries in the release without anyone noticing.