AL Pre-release support?

StefanMaron / BusinessCentral.LinterCop

Community driven code linter for AL (MS Dynamics 365 Business Central)

https://stefanmaron.com

MIT License

79 stars 31 forks source link

AL Pre-release support? #307

Closed fvet closed 1 year ago

fvet commented 1 year ago

@StefanMaron I tend to use the Pre-release version of the AL language extension more, resulting in BCLinterCop not running any longer. Any chance to provide support for BCLinterCop with AL Pre-release option?

jwikman commented 1 year ago

@StefanMaron what happened with this? I thought you fixed that back in april, after the discussion in #146?

I've been using the pre-release version of AL Language the last month, and BCLinterCop seems not to work (anymore?) with that.

Arthurvdv commented 1 year ago

When switching to the Pre-Release version the LinterCop seems to be working? (exception for the Maintainability index on the LC0010 rule. That one seems to be broken)

jwikman commented 1 year ago

When switching to the Pre-Release version the LinterCop seems to be working? (exception for the Maintainability index on the LC0010 rule. That one seems to be broken)

I get 6200+ LC00XX warnings when switching to the Pre-Release version of the AL Language extension. 5500 of them was LC0010, but also a lot of others. It just seems as if the Lintercop dlls isn't built against that runtime.

Arthurvdv commented 1 year ago

@jwikman I've did a rebuild to the latest version of the AL Language (13.0.878831) and unfortunately the LC0010 rule is broken and needs to be resolved. Created an separate issue for following up on that (https://github.com/StefanMaron/BusinessCentral.LinterCop/issues/310).

fvet commented 1 year ago

@StefanMaron @Arthurvdv

Seems like BCLinterCop is again conflicting with the latest pre-lease

Versions installed

Name: AL Language extension for Microsoft Dynamics 365 Business Central
Id: ms-dynamics-smb.al
Description: Development tools for Dynamics 365 Business Central
Version: 13.0.878831
Publisher: Microsoft
VS Marketplace Link: https://marketplace.visualstudio.com/items?itemName=ms-dynamics-smb.al

Name: BusinessCentral.LinterCop
Id: stefanmaron.businesscentral-lintercop
Description: Provides Linting for the AL Language (Business Central)
Version: 0.1.6
Publisher: Stefan Maron
VS Marketplace Link: https://marketplace.visualstudio.com/items?itemName=StefanMaron.businesscentral-lintercop

jwikman commented 10 months ago

@Arthurvdv AL Language Extension Pre-Release v13.0.937154 was released yesterday, and that hangs completely when using LinterCop...

Will there be built a LinterCop-dll for the latest Pre-release version automatically after some time, or do you need to start that manually?

Arthurvdv commented 9 months ago

You're right, there's indeed a new version of the AL Language released, where the LinterCop needs to be compiled again against this specific version.

There's an automation in place that will prepare a new build combined with a manual review to publish this. The new pre-release is there (and seems one or more rules are broken, I'll have to look into that)

jwikman commented 9 months ago

I got the updated BusinessCentral.LinterCop.dll (downloaded @8.22, so should got your updated files) But I just get stuck in the loading of my project:

If I disable LinterCop and restart VSCode, my project is loaded within a few seconds.

So maybe there is some other rule that has failed, that gives us this behavior?

Do you have any AL project that triggers all LinterCop rules, so we can make sure that they still work on new versions?

Edit: Found https://github.com/StefanMaron/Test-App-for-BC.LinterCop. But it seems to need some love to keep up with all the new rules. 😅