search

StefanMaron / BusinessCentral.LinterCop

Community driven code linter for AL (MS Dynamics 365 Business Central)
https://stefanmaron.com
MIT License
72 stars 30 forks source link

Exclude LC0052 and LC0053 on procedure which implements an interface #572 #576

Closed Arthurvdv closed 5 months ago

Arthurvdv commented 5 months ago

@rvanbekkum I've moved the validation for interfaces of a method up in the chain. Do you see any problems with this approach

var objectSymbol = methodSymbol.GetContainingApplicationObjectTypeSymbol();

Is there a benefit of casting this with a var instead of IApplicationObjectTypeSymbol? I've changed this , where I believe I don't need validate the methodSymbol.ContainingSymbol is IApplicationObjectTypeSymbolanymore?

rvanbekkum commented 5 months ago

@rvanbekkum I've moved the validation for interfaces of a method up in the chain. Do you see any problems with this approach

var objectSymbol = methodSymbol.GetContainingApplicationObjectTypeSymbol();

Is there a benefit of casting this with a var instead of IApplicationObjectTypeSymbol? I've changed this , where I believe I don't need validate the methodSymbol.ContainingSymbol is IApplicationObjectTypeSymbolanymore?

I have checked the changes and they look good to me ;)