search

StefanMaron / vsc-lintercop

MIT License
6 stars 6 forks source link

Always support TLS1.2 #8

Closed jwikman closed 1 year ago

jwikman commented 1 year ago

Hi @StefanMaron,

We have a (now quite old) server where some developers are running VSCode. It seems as if TLS1.2 is not supported by default in their PowerShell sessions, so the call to download the dll always fails. (without notice as it seems)

I added one line to add support for TLS1.2 before downloading the dll.

This change is only affecting the running PowerShell session, so it should be pretty harmless.

StefanMaron commented 1 year ago

Thanks, I will try to merge and push this over the weekend

jwikman commented 1 year ago

Hi @StefanMaron,

Are there anything more I can do to help you out here? I assume that you're busy with life :)

One thing could be to rewrite the download logic to use the https module to increase the error handling possibility. Firing of a PowerShell script comes with it's challenges, as noticed. ;)