StefanPeev / Common-Serif

The Common Serif project is based on Libertinus Serif.
SIL Open Font License 1.1
55 stars 3 forks source link

Fractions #35

Closed m-casanova closed 1 year ago

m-casanova commented 1 year ago

I think numerators and denominators vertical positions should be consistent with fraction like /onehalf and /onequarter (and /fraction seems different too)

frac

Also some fractions seem inconsistent (e.g. different denominator positions in /onehalf and /onequarter in Bold)

m-casanova commented 1 year ago

Probably numerators and denominators should be added instead of using superscript and subscript numbers

StefanPeev commented 1 year ago

@m-casanova Thank you for the suggestions. I'll check the issue for the next version.

StefanPeev commented 1 year ago

@m-casanova In Regular:

CommonSerif_1200x625_08

In Bold:

CommonSerif_1200x625_09

m-casanova commented 1 year ago

@StefanPeev I'm sorry. I was referring to fractions created with the opentype "frac" feature, which are inconsistent with built-in fractions (like /onehalf). Example in LibreOffice Writer:

frac2

"frac" feature uses superscript and subscript to create fractions, but I think numerators and denominators should be added. And /fraction should be modified to reflect built-in fractions.

Also the vertical position of numbers in built-in fractions should be checked (e.g. "2" in /onehalf seems slightly higher than "4" in /onequarter; see "8" in ⅛ ⅜ ⅝ ⅞)

StefanPeev commented 1 year ago

@m-casanova New full functioning fraction feature is included in v.1.026.

m-casanova commented 1 year ago

@StefanPeev Sorry to annoy you again. In Italic (v. 1.026) numerators are like superscripts. Example with /onesuperior /one.numr /onehalf and overlapping /one.numr /onehalf

frac3

Also previously width was fixed (tabular) for superscripts and subscripts; now it's variable (proportional) for superscripts, numerators and denominators, while it's fixed for subscripts (Italic and BoldItalic). Personally I prefer fixed width numbers for tables, but I know that different fonts use different methods (e.g. Libertinus and Source Serif use fixed width, while STIX Two Text uses variable width).

frac4

m-casanova commented 1 year ago

Subscript numbers are not consistent with others subscripts

frac

Also sups, numr, dnom and subs height seems inconsistent

frac

StefanPeev commented 1 year ago

@m-casanova Superscript glyphs are a little bit higher then nomerator glyphs and the subscript glyphs are a little bit lower then denominator glyps. Denominators lay on baseline. Here are the pictures for the Normal styles.

CommonSerif_1200x625_10

CommonSerif_1200x625_11

Here are the pictures for the Italic styles.

CommonSerif_1200x625_12 CommonSerif_1200x625_13