search

StefanScherer / dockerfiles-windows

Various Dockerfiles for Windows Containers
MIT License
1.11k stars 396 forks source link

1809 / 2019 support for nodejs #391

Closed pennywisdom closed 5 years ago

pennywisdom commented 5 years ago

Hi @StefanScherer, firstly congratulations on your move to Docker! Second, and this is a general query re nodejs and windows 1809/2019. I see that under the hood things have changed regarding volume mounting and how this is now natively visible in terms of the path inside the container. I was wondering if you have found that this resolves the issues with running nodejs against scripts in a volume (especially permissions and finding the paths correctly). Have you found that this has improved things or do the problems still remain and we need to still copy the files from the mounted volume to a location created in the context of the container?

Thanks

StefanScherer commented 5 years ago

Thanks @pennywisdom, yes the volume mounting is fixed since 1803 as I mentioned that in https://github.com/nodejs/node/issues/8897#issuecomment-429601955 some months ago. So it is time to push https://github.com/nodejs/docker-node/pull/362 a little further, the constraint is not to use multi-stage builds. Maybe I find some time to update my PR.

For now you can use my images that already have 1809/2019 support for the nanoserver based images.

pennywisdom commented 5 years ago

Thanks @StefanScherer . Hmm I get some strange behaviour still when executing node scripts inside the mount. The mount itself is fine. Looks like its permissions related to me. So looks like great progress with the initial volumes issues :) . I am able to mount the volume, then copy to a new location then run the same scripts without problem. This is for nodejs version 6.16 though so might well be related to this older release.

StefanScherer commented 5 years ago

Oh, yes try 8 or 10 which is LTS now.

pennywisdom commented 5 years ago

thanks @StefanScherer