StefanScherer / packer-windows

Windows Templates for Packer: Windows 11, Windows 10, Windows Server 2022, 2019, 2016, also with Docker
MIT License
1.28k stars 430 forks source link

Confusing information in the README.md #291

Closed basictheprogram closed 3 years ago

basictheprogram commented 3 years ago

Maybe a personal problem but the README.md states

All Windows Server versions are defaulted to the Server Standard edition. You can modify this by editing the Autounattend.xml file, changing the ImageInstall>OSImage>InstallFrom>MetaData>Value element

But the answer_files/2019/Autounattend.xml says

            <ImageInstall>
                <OSImage>
                    <InstallFrom>
                        <MetaData wcm:action="add">
                            <Key>/IMAGE/NAME</Key>
                            <Value>Windows Server 2019 SERVERDATACENTER</Value>
                        </MetaData>
                    </InstallFrom>
                    <InstallTo>
                        <DiskID>0</DiskID>
                        <PartitionID>2</PartitionID>
                    </InstallTo>
                </OSImage>
            </ImageInstall>

Shouldn't it be <Value>Windows Server 2019 Standard SERVERSTANDARD</value> (or something like that)? I'm not sure about the SERVERSTANDARD part. Or the documentation changed to match what is actually happening?

PS E:\> Get-WindowsImage -ImagePath .\sources\install.wim

ImageIndex       : 1
ImageName        : Windows Server 2019 Standard
ImageDescription : (Recommended) This option omits most of the Windows graphical environment. Manage with a command
                   prompt and PowerShell, or remotely with Windows Admin Center or other tools.
ImageSize        : 8,388,579,855 bytes

ImageIndex       : 2
ImageName        : Windows Server 2019 Standard (Desktop Experience)
ImageDescription : This option installs the full Windows graphical environment, consuming extra drive space. It can be
                   useful if you want to use the Windows desktop or have an app that requires it.
ImageSize        : 14,668,863,719 bytes

ImageIndex       : 3
ImageName        : Windows Server 2019 Datacenter
ImageDescription : (Recommended) This option omits most of the Windows graphical environment. Manage with a command
                   prompt and PowerShell, or remotely with Windows Admin Center or other tools.
ImageSize        : 8,378,362,786 bytes

ImageIndex       : 4
ImageName        : Windows Server 2019 Datacenter (Desktop Experience)
ImageDescription : This option installs the full Windows graphical environment, consuming extra drive space. It can be
                   useful if you want to use the Windows desktop or have an app that requires it.
ImageSize        : 14,673,479,669 bytes
StefanScherer commented 3 years ago

Oh yes the README needs some update I guess.

basictheprogram commented 3 years ago

I don't know enough about the Autounattend.xml to submit a PR or I would.