StefanosChaliasos / zkrollup-benchmarking

Benchmark zkRollup implementations
MIT License
3 stars 1 forks source link

Timing the different proving steps #3

Open mmagician opened 2 weeks ago

mmagician commented 2 weeks ago

If I'm not mistaken, the benchmark results give times for:

Is this the desired behavior? I would instead expect the following:

It might be worth adding headers to the .csv.

mmagician commented 2 weeks ago

Ah, and also would be great to add the measurement units (ms). Without looking at the patched code it wasn't clear at all, especially since the whole process took a long time.

StefanosChaliasos commented 2 weeks ago

Feel free to add a header including ms.

I will need some time to double-check what times we keep track of. The point is that for our benchmarks, we only care about the first proof, one aggregation, and the final (compression) proof. This is because we only set specific inputs for the first one.