search

SteffeyDev / atemOSC

Control ATEM video switchers over the network with OSC messages
http://www.atemosc.com
202 stars 32 forks source link

Feature/fly and pattern feedback #255

Open reno- opened 2 years ago

reno- commented 2 years ago

I tried to implement fly and pattern feedback, but it does not compile with Xcode, with only one error that I don't know to get rid. I hop that will help to implement feedback for 4.3 version !

SteffeyDev commented 2 years ago

Ok, all you have to do to get it to build is change 

UpstreamKeyerFlyParametersMonitor::Notify(BMDSwitcherKeyFlyParametersEventType eventType)

to

UpstreamKeyerFlyParametersMonitor::Notify(BMDSwitcherKeyFlyParametersEventType eventType, BMDSwitcherFlyKeyFrame keyFrame)

in FeedbackMonitors.mm, and make a similar change in FeedbackMonitors.h by adding BMDSwitcherFlyKeyFrame keyFrame to the Notify function definition. I was able to get it to build with those two files. Please make that change and test to make sure all is working as expected.

reno- commented 2 years ago

Please make that change and test to make sure all is working as expected. Thank you @SteffeyDev . I cannot access to an Atem until a few days, so I cannot test it now. But I will do it asap !

reno- commented 1 year ago

Hi @SteffeyDev , I just test with an Atem 2 M/E, and it works fine with these last changes you can safely merge it. best !