search

SteffeyDev / react-native-popover-view

A well-tested, adaptable, lightweight <Popover> component for react-native
MIT License
613 stars 92 forks source link

Give arrow z-index of 1 so it appears over the popover shadow #104

Closed tecno40 closed 3 years ago

tecno40 commented 3 years ago

In commit 722d97a3e1790110f9d3f75adfced3ebac6e3573 the position of the arrow and pop-over were swapped in the JSX code. This change caused the arrow to now appear under the popover's shadow as opposed to over it which is inconsistent with the design previous versions of react-native-popover-view provided. This may lead to issues with the application design for those trying to upgrade from older version to 4.0.0.

SteffeyDev commented 3 years ago

I'm not a huge fan of zIndex, as it may behave differently on different platforms and can be changed by the various style props. Not sure why I moved it, I'll just move it back to where it was before.

ValTKT commented 3 years ago

Hi, I am still having the same issue on Android. (On iOS it's working great) On the first pic the arrow is white so we can't see it because it's above the shadow. On the second one we can see its here. Do you have any updates about that?

Capture d’écran 2021-09-07 à 11 28 03 Capture d’écran 2021-09-07 à 11 28 31
ValTKT commented 3 years ago

Any updates about this on android?

SteffeyDev commented 3 years ago

Not quite sure I understand the issue, sorry. Is this the same issue the original poster had, with the arrow appearing beneath the popover shadow?

Valar207 commented 3 years ago

Yes it is but on Android this time. On ios it's working great but not on Android.