[fix] Update react to 0.65.1 and do not use RemoveListener on Keyboard

SteffeyDev / react-native-popover-view

A well-tested, adaptable, lightweight <Popover> component for react-native

MIT License

614 stars 92 forks source link

[fix] Update react to 0.65.1 and do not use RemoveListener on Keyboard #118

Closed phyllipecesar closed 3 years ago

phyllipecesar commented 3 years ago

Summary: RemoveListener is deprecated and keeps failing for me since I updated to 0.65.2. The error is quite clear:

_reactnative.keyboard.removelistener is not a function

(https://www.gitmemory.com/issue/react-navigation/react-navigation/9803/895419428)

See docs: https://reactnative.dev/docs/keyboard This removeListener is deprecated

Test Plan: Typescript + deployed in my project

lucasfloriani commented 3 years ago

@SteffeyDev can you give it a look to see if the code is ok to make the merge? I tested here and it works fine Btw thanks for the work on the library, it's awesome \o

SteffeyDev commented 3 years ago

Released as 4.0.3