search

SteffeyDev / react-native-popover-view

A well-tested, adaptable, lightweight <Popover> component for react-native
MIT License
613 stars 92 forks source link

Feature: Placement Array #141

Closed RajRohitYadav closed 2 years ago

RajRohitYadav commented 2 years ago

Hello,

I have added a placement array to handle the priority of the placement. If no Placement in the array suffices the required space, then the placement will be chosen based on best space availability.

I have tested the code for Popover and highly recommend it to be tested for other cases. Also, I have not updated README.

Attaching a video to show behaviour for placement={[PopoverPlacement.RIGHT, PopoverPlacement.TOP]} Video Link

SteffeyDev commented 2 years ago

Thanks for your contribution! I'm going to make a few code style tweaks and test before releasing, but you did a great job adding this feature in an efficient and comprehensive way.

SteffeyDev commented 2 years ago

@RajRohitYadav Released in 5.1.0

RajRohitYadav commented 2 years ago

@SteffeyDev thank you 🤗

Really greatful to work on such an amazing project with you! 🎉