Update Popover.tsx to accept 0 as valid value for x,y,width,height

SteffeyDev / react-native-popover-view

A well-tested, adaptable, lightweight <Popover> component for react-native

MIT License

613 stars 92 forks source link

Update Popover.tsx to accept 0 as valid value for x,y,width,height #144

Closed SeanRoberts closed 2 years ago

SeanRoberts commented 2 years ago

This should solve two issues. First is that typescript is complaining about using a Point as the value for the from prop and the second is that if you do use a Point or an object if any of the coordinates values are 0 it fires off a warning because 0 is falsy.

This may need some further work, not sure!

SteffeyDev commented 2 years ago

Great work, looks good to me

SteffeyDev commented 2 years ago

Released as 5.1.3