Fix bad remount behavior in Popover

SteffeyDev / react-native-popover-view

A well-tested, adaptable, lightweight <Popover> component for react-native

MIT License

614 stars 92 forks source link

Fix bad remount behavior in Popover #48

Closed awinograd closed 5 years ago

awinograd commented 5 years ago

Thanks for the great library!

I'm using it across native + web and I'm noticing a layout bug when re-opening the popover on web. onLayout is getting triggered when the popover is closing with a width/height of 0

Before: https://cl.ly/dcaa642db3df

After: https://cl.ly/abca5ace0edb

SteffeyDev commented 5 years ago

Looks like a good check, thanks! I've never tested with web, glad to hear that it works!

SteffeyDev commented 5 years ago

Ok, v2.0.5 released

awinograd commented 5 years ago

Great thanks!

On Wed, Sep 4, 2019, 7:16 PM Peter Steffey notifications@github.com wrote:

Ok, v2.0.5 released

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/SteffeyDev/react-native-popover-view/pull/48?email_source=notifications&email_token=AACKD6MHBZEAHDE67NHAW5LQIBFUHA5CNFSM4ITLKKC2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD55M6BI#issuecomment-528142085, or mute the thread https://github.com/notifications/unsubscribe-auth/AACKD6KCPVOWQWPEQX3RRO3QIBFUHANCNFSM4ITLKKCQ .