Subtract verticalOffset from popover height to preserve margins on popover

[outaTiME]

Hi, verticalOffset still required on Android on version 2.x when running on expo, and may update the popover height according the vertical offset too (for better experience on large popovers like the image attached)

here snippet and screenshots, thanks and awesome work !!!

btw: on iOS works as expected.

<TouchableOpacity
  ref={ref => (this._controls_button_ref = ref)}
  style={{
    position: 'absolute',
    top: 0,
    right: 0
  }}
  onPress={this._showControls}
>
  <Text>Button</Text>
</TouchableOpacity>
<Popover
  isVisible={showControls}
  fromView={this._controls_button_ref}
  onRequestClose={this._onPressCancel}
  verticalOffset={
    Platform.OS === 'android' ? -Constants.statusBarHeight : 0
  }
>
  <View>Stuff here</View>
</Popover>

[SteffeyDev]

I’m not entirely sure what the issue is, the popover in the image appears to be working as expected, except maybe slightly offset horizontally. Can you please restate what the issue is exactly, describing the expected behavior and actual behavior of the popover?

[outaTiME]

Hi @SteffeyDev, the popover height should sustract verticalOffset for better vertical alignment on the screen.

And additionally I made the clarification that the verticaloffset is still required in Expo.

[SteffeyDev]

I agree that the verticalOffset should shift the popover, and from your picture it appears to be working correctly, because if it were not the arrow would not point to the button. Again, what is the issue? What is not working correctly?

[outaTiME]

Yup, its working correctly but this is a little enhacement for better popview alignment, check out the following image:

I hope it serves as clarification 🙏

[SteffeyDev]

Ah that is amazing clarification, thanks! I'll do that as part of the next release.

[SteffeyDev]

In the latest version (4.0.0), the vertical offset is applied before margins, so this should be fixed. Re-open if it is still an issue in the latest version.