SteffiPeTaffy / conference-rating

Eclipse Public License 1.0
12 stars 4 forks source link

Minor fixes #16

Closed ghost closed 9 years ago

ghost commented 9 years ago

Please review these changes and merge them if you see fit.

Regards @cochrane343

flosell commented 9 years ago

Hey, thanks for the fixes, looks good. I would just change one thing: Since the title is static anyway, I wouldn't set it on the client side in ClojureScript code but instead just add it to the initial HTML generated on the server: https://github.com/SteffiPeTaffy/conference-rating/blob/master/src/clj/conference_rating/handler.clj#L18

ghost commented 9 years ago

Yes, that makes sense. I moved the code over to the server side.

flosell commented 9 years ago

Thanks!