search

SteffiPeTaffy / conference-rating

Eclipse Public License 1.0
12 stars 4 forks source link

Special characters in location show up escaped, non-latin characters become question marks #94

Closed flosell closed 4 years ago

flosell commented 6 years ago

The location field (probably others as well) can't handle special characters (like &) and non-latin characters:

screen shot 2018-06-03 at 09 27 16

Was supposed to be "Growth cafe & co. - 236/8-9 ซอย สยามสแควร์ 2 Khwaeng Pathum Wan, Khet Pathum Wan, Krung Thep Maha Nakhon 10330"

flosell commented 4 years ago

Thanks @marcos-mercuri-tw for fixing the special character issue!

Re-opening this as the & characters aren't fixed yet: Screenshot 2020-04-02 at 09 05 23

m-mercuri commented 4 years ago

Hi, @flosell, For what I could see the & (and other html characters) is being escaped here. I see the commit was to address this issue, Was this trying to fix a specific bug?

flosell commented 4 years ago

Hi @marcos-mercuri-tw, I believe this was done as a quick way to address a concern in our security review, storing unsafe characters in the DB. This could probably be improved though.

I'll forward our discussion with the reviewers via E-Mail for more details.

flosell commented 4 years ago

Fixed in #96, thanks @marcos-mercuri-tw !