StellarCartography / pydis

DEPRECATED: Check out PyKOSMOS!
https://github.com/jradavenport/pykosmos
MIT License
43 stars 27 forks source link

Autoreduce: Dis-high data in blue #36

Closed tdwilkinson closed 9 years ago

tdwilkinson commented 9 years ago

First, thanks to your last changes, this a sample of great DIS-high data reduction (in red): kic5597604 16r

It was so quick ! So, I decided to try it with the blue images. The results were... interesting. I ran the pydis.autoreduce the first time with the red henear by accident: kic2285598 11b_r

The results were off, and I found the error in my code. This is what I got with the blue henear: hmmm 15b It seems we have discovered plasma dragons.

I'm not sure why the blue images would reduce differently than the red. I looked in pydis.py and could not find anything. On my side, I double checked my lists, and all seem to be the same. The next DIS-high night I ran with pydis.autoreduce also looked good in the red, and the same distortions appeared in the blue.

jradavenport commented 9 years ago

this wacky result is when the HeNeAr gets solved poorly. Consider: you're fitting a polynomial to describe wavelength versus pixel number. That polynomial could turn over and start going back down again, which would cause the spectrum to "double over" on itself.

Be sure to do the Blue HeNeAr with care! And be careful when fitting to polynomial!

jradavenport commented 9 years ago

Are you doing the HeNeAr manually for both the red/blue?

tdwilkinson commented 9 years ago

Okay, that makes sense. I was using interact=False, so I was expecting to rerun these to get more robust results anyway.

tdwilkinson commented 9 years ago

Whoa. :) I was just running the quick autorun script to get through all of the nights of data. Then, I am going to run the red side manually from there.

jradavenport commented 9 years ago

It's an interesting bug, i'll create a new issue for it. Not entirely clear to me at the moment how to solve it, but we should impose the condition that wavelength must monotonically change and not turn over!