StellarWind22 / Fabric-Shield-Lib

Library for easily adding new shields, shield enchantments, and enabling you to enchant shields in general without worry of conflictions.
https://www.curseforge.com/minecraft/mc-mods/fabric-shield-lib
GNU Lesser General Public License v2.1
40 stars 19 forks source link

[1.19.2] Fabric Shield Crash #142

Closed itsdinkd closed 11 months ago

itsdinkd commented 1 year ago

occurred on my modpack, another quality modpack 2.

Updated to shield API 1.7 and crashed upon entering game

https://pastebin.com/JpakGKAx

CringeStar commented 1 year ago

It seems like the mod "MobZ" or something like that changes the getCooldownTicks() method, causing an error. Could you please link that mod and provide the version of it?

CringeStar commented 1 year ago

I looked at their code. seems this is the file causing the issue. https://github.com/rikka0w0/MobZReborn/blob/3835fe46b28b39d48ffbceaa6bf364863b9f42e2/fabric/src/main/java/net/mobz/mixin/MetalShieldMixin.java#L5

It overrides the getCooldownTicks() method:

@Mixin(Shield.class)
public abstract class MetalShieldMixin implements FabricShield {
    @Override
    public int getCooldownTicks() {
        return 100;
    }

    @Override
    public boolean supportsBanner() {
        return false;
    }
}
Sunconure11 commented 1 year ago

https://bytebin.lucko.me/SBlm0liXxo

Encountered the same issue.

@StellarWind22 @rikka0w0

Chris-Creates commented 1 year ago

so whats the solution? do we bother mobz creator to fix it instead? sounds like a mobz issue then.

CringeStar commented 1 year ago

Seems so, and I have opened an issue on their Github, https://github.com/rikka0w0/MobZReborn/issues/35, but they haven't responded. @rikka0w0

CringeStar commented 11 months ago

fixed by other mod dev