StellarWind22 / Fabric-Shield-Lib

Library for easily adding new shields, shield enchantments, and enabling you to enchant shields in general without worry of conflictions.
https://www.curseforge.com/minecraft/mc-mods/fabric-shield-lib
GNU Lesser General Public License v2.1
40 stars 19 forks source link

Custom banner shield uses FabricShieldLib shield texture when blocking #176

Closed Partonetrain closed 7 months ago

Partonetrain commented 7 months ago

https://github.com/StellarWind22/Fabric-Shield-Lib/assets/19861808/75f9f5e7-306a-439a-ac0d-d8ce6e1dd7b2

The tutorial (https://fabricmc.net/wiki/tutorial:shield) has the blocking model parent from fabric_banner_shield_blocking and doesn't specify the texture. image

However, specifying the texture like so in the blocking model (my JSON) results in the shield using the default Minecraft missing texture.

  "textures":{
    "shield":"botaniacombat:entity/elementium_banner_shield"
  }

image

CringeStar commented 7 months ago

Thanks for catching this! It seems I changed it in the code but not in the wiki, will fix in a sec!

CringeStar commented 7 months ago

fixed

Partonetrain commented 7 months ago

Thanks for the quick response, but there still seems to be an issue. using "textures":{ "shield":"examplemod:item/netherite_shield" } (which is what the wiki has now) in the blocking model uses the non-banner-compatible shield texture. It looks like the banner disappears when blocking.

CringeStar commented 7 months ago

thats not what happens on my end, could you please show your project, preferably as a github repo?

Partonetrain commented 7 months ago

D'oh, I had it parented to fabricshieldlib:item/fabric_shield_blocking instead of fabricshieldlib:item/fabric_banner_shield_blocking, which is why it didn't work. My apologies, and thanks for your patience, haha.

CringeStar commented 7 months ago

It's all good! Happy you got it sorted out.