search

StellarWind22 / Fabric-Shield-Lib

Library for easily adding new shields, shield enchantments, and enabling you to enchant shields in general without worry of conflictions.
https://www.curseforge.com/minecraft/mc-mods/fabric-shield-lib
GNU Lesser General Public License v2.1
40 stars 19 forks source link

1.19 support #92

Closed kanpov closed 2 years ago

kanpov commented 2 years ago

Your mod is a major dependency for many others, like mine, so it is a blocker for updating mods that ShieldLib is on 1.18.2. I can make a PR updating it myself, if you'd like.

StellarWind22 commented 2 years ago

If you want to open a PR go right ahead. I just haven't had time to work on this project lately. I only recently got my pc working again.

kanpov commented 2 years ago

If you want to open a PR go right ahead. I just haven't had time to work on this project lately. I only recently got my pc working again.

I've opened a pull request over at #94, sorry if it's a bit late.

rikka0w0 commented 2 years ago

Compiling the latest commit gave me this:

> Task :compileJava
/home/rikka/workspace/mc/Fabric-Shield-Lib/src/main/java/com/github/crimsondawn45/fabricshieldlib/lib/object/FabricBannerShieldItem.java:56: error: cannot find symbol
        if(FabricLoader.getInstance().getEnvironmentType() == EnvType.CLIENT) {
           ^
  symbol:   variable FabricLoader
  location: class FabricBannerShieldItem
/home/rikka/workspace/mc/Fabric-Shield-Lib/src/main/java/com/github/crimsondawn45/fabricshieldlib/lib/object/FabricBannerShieldItem.java:56: error: cannot find symbol
        if(FabricLoader.getInstance().getEnvironmentType() == EnvType.CLIENT) {
                                                              ^
  symbol:   variable EnvType
  location: class FabricBannerShieldItem
/home/rikka/workspace/mc/Fabric-Shield-Lib/src/main/java/com/github/crimsondawn45/fabricshieldlib/lib/object/FabricBannerShieldItem.java:80: error: cannot find symbol
        if(FabricLoader.getInstance().getEnvironmentType() == EnvType.CLIENT) {
           ^
  symbol:   variable FabricLoader
  location: class FabricBannerShieldItem
/home/rikka/workspace/mc/Fabric-Shield-Lib/src/main/java/com/github/crimsondawn45/fabricshieldlib/lib/object/FabricBannerShieldItem.java:80: error: cannot find symbol
        if(FabricLoader.getInstance().getEnvironmentType() == EnvType.CLIENT) {
                                                              ^
  symbol:   variable EnvType
  location: class FabricBannerShieldItem
/home/rikka/workspace/mc/Fabric-Shield-Lib/src/main/java/com/github/crimsondawn45/fabricshieldlib/lib/object/FabricBannerShieldItem.java:105: error: cannot find symbol
        if(FabricLoader.getInstance().getEnvironmentType() == EnvType.CLIENT) {
           ^
  symbol:   variable FabricLoader
  location: class FabricBannerShieldItem
/home/rikka/workspace/mc/Fabric-Shield-Lib/src/main/java/com/github/crimsondawn45/fabricshieldlib/lib/object/FabricBannerShieldItem.java:105: error: cannot find symbol
        if(FabricLoader.getInstance().getEnvironmentType() == EnvType.CLIENT) {
                                                              ^
  symbol:   variable EnvType
  location: class FabricBannerShieldItem
/home/rikka/workspace/mc/Fabric-Shield-Lib/src/main/java/com/github/crimsondawn45/fabricshieldlib/lib/object/FabricBannerShieldItem.java:130: error: cannot find symbol
        if(FabricLoader.getInstance().getEnvironmentType() == EnvType.CLIENT) {
           ^
  symbol:   variable FabricLoader
  location: class FabricBannerShieldItem
/home/rikka/workspace/mc/Fabric-Shield-Lib/src/main/java/com/github/crimsondawn45/fabricshieldlib/lib/object/FabricBannerShieldItem.java:130: error: cannot find symbol
        if(FabricLoader.getInstance().getEnvironmentType() == EnvType.CLIENT) {
                                                              ^
  symbol:   variable EnvType
  location: class FabricBannerShieldItem
/home/rikka/workspace/mc/Fabric-Shield-Lib/src/main/java/com/github/crimsondawn45/fabricshieldlib/lib/object/FabricShieldItem.java:52: error: cannot find symbol
        if(FabricLoader.getInstance().getEnvironmentType() == EnvType.CLIENT) {
           ^
  symbol:   variable FabricLoader
  location: class FabricShieldItem
/home/rikka/workspace/mc/Fabric-Shield-Lib/src/main/java/com/github/crimsondawn45/fabricshieldlib/lib/object/FabricShieldItem.java:52: error: cannot find symbol
        if(FabricLoader.getInstance().getEnvironmentType() == EnvType.CLIENT) {
                                                              ^
  symbol:   variable EnvType
  location: class FabricShieldItem
/home/rikka/workspace/mc/Fabric-Shield-Lib/src/main/java/com/github/crimsondawn45/fabricshieldlib/lib/object/FabricShieldItem.java:76: error: cannot find symbol
        if(FabricLoader.getInstance().getEnvironmentType() == EnvType.CLIENT) {
           ^
  symbol:   variable FabricLoader
  location: class FabricShieldItem
/home/rikka/workspace/mc/Fabric-Shield-Lib/src/main/java/com/github/crimsondawn45/fabricshieldlib/lib/object/FabricShieldItem.java:76: error: cannot find symbol
        if(FabricLoader.getInstance().getEnvironmentType() == EnvType.CLIENT) {
                                                              ^
  symbol:   variable EnvType
  location: class FabricShieldItem
/home/rikka/workspace/mc/Fabric-Shield-Lib/src/main/java/com/github/crimsondawn45/fabricshieldlib/lib/object/FabricShieldItem.java:101: error: cannot find symbol
        if(FabricLoader.getInstance().getEnvironmentType() == EnvType.CLIENT) {
           ^
  symbol:   variable FabricLoader
  location: class FabricShieldItem
/home/rikka/workspace/mc/Fabric-Shield-Lib/src/main/java/com/github/crimsondawn45/fabricshieldlib/lib/object/FabricShieldItem.java:101: error: cannot find symbol
        if(FabricLoader.getInstance().getEnvironmentType() == EnvType.CLIENT) {
                                                              ^
  symbol:   variable EnvType
  location: class FabricShieldItem
/home/rikka/workspace/mc/Fabric-Shield-Lib/src/main/java/com/github/crimsondawn45/fabricshieldlib/lib/object/FabricShieldItem.java:126: error: cannot find symbol
        if(FabricLoader.getInstance().getEnvironmentType() == EnvType.CLIENT) {
           ^
  symbol:   variable FabricLoader
  location: class FabricShieldItem
/home/rikka/workspace/mc/Fabric-Shield-Lib/src/main/java/com/github/crimsondawn45/fabricshieldlib/lib/object/FabricShieldItem.java:126: error: cannot find symbol
        if(FabricLoader.getInstance().getEnvironmentType() == EnvType.CLIENT) {

Adding the missing imports does give me a jar file.

CringeStar commented 2 years ago

Should now be working properly

StellarWind22 commented 2 years ago

Sorry I was gone for quite awhile. I finally have a working computer and time to use it. So far with the pull request from @CringeStar everything seems to be working & I'm working on getting it out on jitpack right now.

StellarWind22 commented 2 years ago

The mod is out for 1.19 It's currently waiting for approval on curseforge so anywhere from the next 10 minutes to 10 hours lol.