search

Stellarium / stellarium

Stellarium is a free GPL software which renders realistic skies in real time with OpenGL. It is available for Linux/Unix, Windows and macOS. With Stellarium, you really see what you can see with your eyes, binoculars or a small telescope.
https://stellarium.org
GNU General Public License v2.0
7.77k stars 821 forks source link

ShowMySky: Color "jump" at begin/end of eclipse time #2914

Open gzotti opened 1 year ago

gzotti commented 1 year ago

ShowMySky provides a magnificent "eclipse sky" simulation. It is graphically much more involved (i.e. shows only a few fps during eclipse) than regular daylight sky, so it is only used during at least minimal coverage of the sun by the moon.

Expected Behaviour

Transition between regular and eclipse mode goes unnoticed in the sky color.

Actual Behaviour

In all eclipse mode settings: At the time of first (or last) contact, the blue shade of the sky changes.

Steps to reproduce

Check with any Solar eclipse.

I don't know the details of this issue, do we just have different atmosphere compositions, or is there a systematic flaw?

System

Logfile

If possible, attach the logfile log.txt from your user data directory. Look into the Guide for its location.

10110111 commented 1 year ago

Indeed, looks bad. I wonder how I didn't notice it before.

I don't know the details of this issue

The issue is that in eclipsed atmosphere only two scattering orders are considered, while in the common case more orders are included.

Atque commented 1 year ago

Is this bug still present? I can't reproduce it.

luzpaz commented 1 year ago

@Atque can you specify the version you tested ?

Atque commented 1 year ago

@luzpaz Okay, I can reproduce this with eclipse quality 2 and 3, but not with 1.