AstroCalc: Avoid the frequent core updates when computing eclipses

Stellarium / stellarium

Stellarium is a free GPL software which renders realistic skies in real time with OpenGL. It is available for Linux/Unix, Windows and macOS. With Stellarium, you really see what you can see with your eyes, binoculars or a small telescope.

https://stellarium.org

GNU General Public License v2.0

7.74k stars 820 forks source link

AstroCalc: Avoid the frequent core updates when computing eclipses #3183

Open gzotti opened 1 year ago

gzotti commented 1 year ago

Actual Behaviour

Currently, when searching for eclipses, I see frequent calls of

core->setJD(jd);
core->update(0);

This triggers a computation of the whole SolarSystem, but later in these methods all we need are positions of Sun, Earth and Moon.

It would certainly speed up things if we would call the respective position functions just for the three.

Steps to reproduce

System

Stellarium version: 23.1
Operating system: all

github-actions[bot] commented 1 year ago

Hello @gzotti!

Thank you for suggesting this enhancement.