Stellarium / stellarium

Stellarium is a free GPL software which renders realistic skies in real time with OpenGL. It is available for Linux/Unix, Windows and macOS. With Stellarium, you really see what you can see with your eyes, binoculars or a small telescope.
https://stellarium.org
GNU General Public License v2.0
7.83k stars 829 forks source link

changing location re-enables atmosphere 23.1.141-c98b3c9 #3250

Closed axd1967 closed 1 year ago

axd1967 commented 1 year ago

Expected Behaviour

When disabling atmosphere and moving around, atmosphere should remain off

Actual Behaviour

Atmosphere is re-activated

Steps to reproduce

  1. disable atmosphere (A)
  2. open location dialog (F6)
  3. move location

Bug: atmosphere is enabled

System

Operating System: Kubuntu 20.04 KDE Plasma Version: 5.18.8 KDE Frameworks Version: 5.68.0 Qt Version: 5.12.8 Kernel Version: 5.4.0-148-generic OS Type: 64-bit Processors: 8 × Intel® Core™ i7-10510U CPU @ 1.80GHz Memory: 15.3 GiB of RAM

Logfile

If possible, attach the logfile log.txt from your user data directory. Look into the Guide for its location.

alex-w commented 1 year ago

I guess the option for automatic enabling the environment is enabled in settings, so, in this case this is not a bug

axd1967 commented 1 year ago

I guess the option for automatic enabling the environment is enabled in settings, so, in this case this is not a bug

Which setting would that be?

image image

axd1967 commented 1 year ago

Aha, this one

image

axd1967 commented 1 year ago

I think that setting should have an influence only when jumping to another body, not while moving around on a body.

The description clearly says so: https://github.com/Stellarium/stellarium/blob/64e0e4279d4a52e22b82518ec3ae04cd278f5368/guide/ch_interface.tex#L340-L341

and https://github.com/Stellarium/stellarium/blob/64e0e4279d4a52e22b82518ec3ae04cd278f5368/plugins/RemoteControl/webroot/index.html#L310

so, only when changing planet.

also, the description should read "when changing the body" (because this also works for e.g Vesta, even if it doesn't make much sense: if auto enable is set, this will also set atmosphere when jumping from Earth to Vesta).

gzotti commented 1 year ago

3180

github-actions[bot] commented 1 year ago

Hello @axd1967!

Please check the fresh version (development snapshot) of Stellarium: https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot