search

Stellarium / stellarium

Stellarium is a free GPL software which renders realistic skies in real time with OpenGL. It is available for Linux/Unix, Windows and macOS. With Stellarium, you really see what you can see with your eyes, binoculars or a small telescope.
https://stellarium.org
GNU General Public License v2.0
7.65k stars 818 forks source link

Wrong character in Meade LX200 comand #3451

Closed labrat0638 closed 9 months ago

labrat0638 commented 1 year ago

I checked serial port communication in telescope control plugin. Since I made and build own GOTO implementation (on Arduino) it worked flawlessly in Stellarium with Meade LX200 protocol. Until problems with Qt6 versions. Now it mainly fixed, congratulations. But now I noticed Arduino does not react properly on sent by Stellarium target coordinates. I sniffed USB communication with program Device Monitoring Studio. Now Stellarium uses weird character instead [*] in this command: :SdsDD*MM:SS#. (Look into attachments)

Expected Behaviour

Comand in old version

This is implementation according to known to me MEADE LX200 protocol documentation. ( I older versions like: 0.20.2)

Actual Behaviour

Comand in new version

This is implementation with not expected sign (in Stellarium 23.3)

System

github-actions[bot] commented 1 year ago

Thanks for adding your first issue to Stellarium. If you have questions, please do not hesitate to contact us.

alex-w commented 1 year ago

Please attach your LX200 protocol documentation

10110111 commented 1 year ago

Here is the source of this character in Stellarium's output:

    p[-6] = '\xDF'; // = 223, degree symbol. This is always printed as asterisk in the specs, very confusing.
labrat0638 commented 1 year ago

TelescopeProtocol_2010-10.pdf page: 13

command-protocol-v2.13.2.pdf page: 27

10110111 commented 1 year ago

Here we can also find the discussion of ° sign denoted by * in the manuals:

the degree symbol (ASCII 223 '°' [0xdf]) non-terminal is used as the separator character in degrees and minutes. This character is shown as an asterisk (ASCII 0x2a '*') in the manual for both the 16-inch and smaller telescopes and is followed by a note in the manual describing the ASCII value of the character.

10110111 commented 1 year ago

Finally, your second document discusses the meaning of the asterisk in Commands section on page 2.

labrat0638 commented 1 year ago

So, this mean the older versions of Stellarium had wrong implementation. Thanks for quick response.

gzotti commented 1 year ago

Groundhog day? Years ago I found a mismatch between code and specs, tried to repair according to the specs. Users complained this broke the program. We reverted, and all users were happy again. Now a problem appears in some Arduino implementation. Is the program currently working with genuine LX200 systems?

labrat0638 commented 1 year ago

Groundhog day? Years ago I found a mismatch between code and specs, tried to repair according to the specs. Users complained this broke the program. We reverted, and all users were happy again. Now a problem appears in some Arduino implementation. Is the program currently working with genuine LX200 systems?

Exactly, I can adapt my Arduino project to current Stellarium implementation, but owners of Meade Telescopes not so much.

gzotti commented 10 months ago

Can we close this?

gzotti commented 9 months ago

We can presumably close this as resolved. The "unexpected" character 223 is actually required.