Stellarium / stellarium

Stellarium is a free GPL software which renders realistic skies in real time with OpenGL. It is available for Linux/Unix, Windows and macOS. With Stellarium, you really see what you can see with your eyes, binoculars or a small telescope.
https://stellarium.org
GNU General Public License v2.0
7.48k stars 809 forks source link

wrong highligting [observation lists] #3746

Open axd1967 opened 3 months ago

axd1967 commented 3 months ago

Expected Behaviour

'Highlight all' should take setting of coordinates into account. This checkbox does not exist yet.

When this checkbox is cleared, actual positions should be highlighted. When this checkbox is set, highlighting can show the position as stored in the obs list.

Additionally, toggling the coordinates checkbox should re-run the highlighting routine (toggling between current and stored coordinates, but only if the information is stored in the obs list).

image

This is similar to double-clicking from within an obs list line, where the behaviour depends on whether date (set->jump to date), location (set->jump to location), FOV, etc are selected.

Actual Behaviour

Highlighted coordinates do not correspond to actual coordinates image

Steps to reproduce

  1. F3/select a comet (anything that moves significantly)
  2. edit obs list
  3. enable coordinates and date
  4. add object
  5. save list
  6. highlight all
  7. observe that the selected object is highlighted
  8. advance date/time sufficiently so that the selected object is away from its current coordinates
  9. highlight all

BUG: the coordinates as stored in step 4 are highlighted, rather than the current coordinates of the object This makes the highlight feature less interesting, as the intention is to highlight the object, not the coordinates it was at some point in time (unless the new checkbox "coordinates" is set).

Workaround

Store the same object without coordinates.

System

alex-w commented 3 months ago

Highlight should work for actual positions

gzotti commented 3 months ago

This may have been the reason to always store coordinates (see OP's #3694): so that we are able to show such highlights. Maybe the highlight labels should include the stored date in case of SSOs where you may have multiple entries. To highlight/find any object at some arbitrary current date, just use the Search dialog (F3).