Stellarium / stellarium

Stellarium is a free GPL software which renders realistic skies in real time with OpenGL. It is available for Linux/Unix, Windows and macOS. With Stellarium, you really see what you can see with your eyes, binoculars or a small telescope.
https://stellarium.org
GNU General Public License v2.0
7.72k stars 820 forks source link

Tint landscapes orange and red at sunrise/sunset #3855

Closed Atque closed 1 month ago

Atque commented 2 months ago

A small but visually beautiful tweak would be for landscape panoramas to progressively tint yellow, orange and red once the Sun rises or sets, to adjust for the different coloring of the scenery.

Could also be applied to 3D Sceneries.

Values could possibly be called from the current extinction reddening tweak.

10110111 commented 2 months ago

It's not small if we don't want to put it in by hand, hard-coding the gradients into the scenery.

It's theoretically possible to implement using the techniques of ShowMySky, but there may be some issues, kludges for which were implemented in Bruneton's demo (see e.g. this discussion).

10110111 commented 2 months ago

Hmm, or did you just mean that simply the direct lighting color should change? This may not be hard indeed.

Atque commented 2 months ago

Hmm, or did you just mean that simply the direct lighting color should change? This may not be hard indeed.

Yes, I was thinking something like that. A few other planetaria have it, such as Starry Night.

github-actions[bot] commented 2 months ago

Hello @Atque!

Thank you for suggesting this feature.

gzotti commented 2 months ago

Just using a "tinted" sunlight color (same as used for e.g. the sun glare) for the landscape is easy. However, I feel the reddening should go away with the sun hiding behind the landscape. Likewise not that hard. In some scenes it may look weird, like the "Trees", with the sun blinking through the trees, it will then blink "white/yellow", depending on whether the sun is hidden behind landscape pixels. I am preparing a PR to test this.

github-actions[bot] commented 1 month ago

Hello @Atque!

Please check the fresh version (development snapshot) of Stellarium: https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

github-actions[bot] commented 1 month ago

Hello @Atque!

Please check the latest stable version of Stellarium: https://github.com/Stellarium/stellarium/releases/latest