search

Stengo / DeskPad

A virtual monitor for screen sharing
MIT License
956 stars 40 forks source link

Add missing 16:9 resolutions up to 1920x1080 #10

Closed seclerp closed 11 months ago

seclerp commented 12 months ago

Fix #5

Motivation

When presenting the screen at online conferences or in another fullscreen-required environment the black boxes occur because of differences in aspect ratio. 16:9 is more popular and this wonderful software really misses it.

Acknowledgments

These changes are based on @dtinth's work in https://github.com/dtinth/DeskPad/commit/5f13f76fb10177f594561c356661e9c002a9907d.

P.S. For some reason, setting maxPixelsWide and maxPixelsHigh into 4K resolution breaks the DeskPad for me. So I don't have the ability to test higher resolutions and don't want to include untested/not working code in that PR.

P.S.S. Build is not working for me unless I change MACOSX_DEPLOYMENT_TARGET to 13.0.

seclerp commented 11 months ago

@Stengo could you please take a look?

aakin commented 11 months ago

@Stengo: I agree with @seclerp, I've added this also to my local version. It would be nice if this change PR can be reviewed.

Stengo commented 11 months ago

Thank you so much @seclerp for taking care of this and sorry for the glacial response!

Stengo commented 11 months ago

I just created a new release 1.1 that contains this change 🚀

Since I got a personal paid developer account since releasing 1.0 I was also able to codesign the app and have it verified by Apple, so hopefully it's now easier to install.