Closed EarlOrlando closed 10 months ago
@Stengo, please look at this pull request when you have time. Feel free to reach out if needed. Thanks in advance.
Amazing! Love your work:)
I genuinely appreciate the effort you've put into reworking my PR! It was incredibly enlightening to see how the same result could be achieved with a much simpler approach, leading to a more robust architecture. This experience has been a valuable learning curve for me, nurturing a strong interest in dedicating more time to Swift and understanding the Redux architecture. As someone from a Firmware background, this is an entirely new world for me.
One final note: the concept of enabling or disabling window resizing, combined with custom resolutions, provides a practical means to lock in the desired window size. I assume users hardly ever change it once it's initially set up (it could actually be annoying if the window keeps changing its size by mistake, resulting in an unwanted fuzzy image).
Personally, I rely on the Rectangle app to organize my windows on my Ultrawide Monitor. I use keyboard shortcuts to position my windows (usually arranging them in the center, left half, or right half), and having the DeskPad window size locked helps maintain the 1:1 window-to-pixel ratio when re-positioning it. I felt it was worth mentioning.
However, similar to the custom resolutions, this is something I can manage in my fork.
I reset my branch to yours. You wrote the code so the credit is yours :) Feel free to approve and merge!
This pull request addresses the following improvements: