search

Stengo / DeskPad

A virtual monitor for screen sharing
MIT License
956 stars 40 forks source link

Only shows 16:10 aspect ratios #5

Closed lukepighetti closed 11 months ago

lukepighetti commented 1 year ago

Would love an option for normal 16:9 1920x1080 pixel doubled, and 1280x720 pixel doubled

Screenshot 2023-02-23 at 1 36 37 PM
jordanrvillarreal commented 1 year ago

I'd like to +1 this. I've been using DeskPad for presenting over Zoom/Teams/WebEx/etc and having a more common (16:9) screen resolution would be tremendously helpful for the people on the receiving end of my presentations. I'll occasionally do some screen recording for YouTube/LinkedIn/etc and 16:9 would be nice to have there as well.

dchuk commented 1 year ago

I'm no expert on this, but shouldn't that be as simple as adding more resolutions here? https://github.com/Stengo/DeskPad/blob/main/DeskPad/Frontend/Screen/ScreenViewController.swift#L38

` let settings = CGVirtualDisplaySettings()

    settings.modes = [

        CGVirtualDisplayMode(width: 1920, height: 1200, refreshRate: 60),

        CGVirtualDisplayMode(width: 1680, height: 1050, refreshRate: 60),

        CGVirtualDisplayMode(width: 1440, height: 900, refreshRate: 60),

        CGVirtualDisplayMode(width: 1280, height: 800, refreshRate: 60),

    ]

    display.apply(settings)`

I can try and fire this up on my side and make the change to get more familiar with the project.

jmcurbelo commented 1 year ago

Same issue, In my case I need a resolution of 1920x1080p. I downloaded the project to built it in my mac but some functions are deprecated in Xcode. I would be great add this resolution too.

dtinth commented 1 year ago

Following @dchuk’s comment works well for me. I added 1080p, 4K, and 1080p-HiDPI mode in my fork. See this commit for changes:

https://github.com/dtinth/DeskPad/commit/5f13f76fb10177f594561c356661e9c002a9907d