search

Step7750 / node-csgo-cdn

Retrieves the Steam CDN Image URLs for CS:GO Items
MIT License
73 stars 19 forks source link

Fix missing sticker images #26

Closed Maciej916 closed 3 years ago

Maciej916 commented 4 years ago

Some sticker images are missing adding .toLowerCase() seems to fix the issue

Step7750 commented 3 years ago

Sorry for not looking into this earlier. Which sticker images were missing specifically?

danieldspx commented 3 years ago

Sorry for not looking into this earlier. Which sticker images were missing specifically?

I do not think the stickers are missing for this PR. The problem is that if you pass the filename to the getStickerURL and any letter is upper case, it wont work because all files in VPK are lower case. So this PR would make the life of anyone using this package easier by not having to know that filename must be all lower case.

Step7750 commented 3 years ago

If we want to go the case-insensitive route, then the filenames in the vpk should also be converted to all lowercase. There are a couple uppercase letters in some materials afaik and it's a bad assumption that Valve won't add further material paths with upper-case letters.

Step7750 commented 3 years ago

Closing this PR, but feel free to re-open with the edits if you'd like!