search

Step7750 / node-csgo-cdn

Retrieves the Steam CDN Image URLs for CS:GO Items
MIT License
73 stars 19 forks source link

Add Patches Support #36

Closed Namvarii closed 3 years ago

Namvarii commented 3 years ago

Some stickers are stored in econ/patches directory. Fixed to get That Stickers.

danieldspx commented 3 years ago

@Step7750 this PR seems to fix missing stickers. Agents have a special kind of sticker that are located in 'resource/flash/econ/patches'. If you use CSGOFloat-Inspect you will get the material in the kit.patch_material (not in the usual kit.sticker_material).

So for example, the material case01/patch_hydra would not be found, but with this fix it will. Because the complete path for this sticker is: resource/flash/econ/patches/case01/patch_hydra.png or resource/flash/econ/patches/case01/patch_hydra_large.png. So normal and large works just fine.

I really want to use this library but if this PR does not get merged I will have to fork it just to use the fixed version.

danieldspx commented 3 years ago

Also, it seems to me that the PR title is unclear.

Step7750 commented 3 years ago

I don't think we should be conflating stickers and patches here.

There should be separate a separate method for getPatchUrl or similar.

danieldspx commented 3 years ago

seems reasonable to me. I will make a PR with that change right away.