Closed StephMode closed 1 week ago
Pivot on Standardize naming of Component.jsx
There is no fixed spec for naming .jsx
files as React is unopinionated on this. See: https://stackoverflow.com/questions/43973199/file-naming-conventions-in-reactjs.
I'll stick with PascalCase
for naming of my Component.jsx
files. Instead, I'll rename the ContrastChecker
file.
Pivot on Standardize naming of Component.jsx
There is no fixed spec for naming
.jsx
files as React is unopinionated on this. See: https://stackoverflow.com/questions/43973199/file-naming-conventions-in-reactjs.I'll stick with
PascalCase
for naming of myComponent.jsx
files. Instead, I'll rename theContrastChecker
file.
Accidentially commited it to main
. Will open refactor
branch now.
decided to leave the following comps as they are for now: CopyTo: comments are hints for improvements and refactoring. They are useful and shall remain. ColorInput: Have to work on it for a bug fix anyway, so leave it as it is for now
Overview
There are inconsistencies regarding naming of the files:
There are empty
css
files which need to be deleted, such asColorEditor.css
.There are inconsistencies in the css. 🟢 Sometimes I use class selectors, like in
ColorForm.css
🔴 Sometimes I use type selectors, like inContrastChecker.css
=> I should use class selectors everywhere.Several
.jsx
files contain unneccesary logs, code that's commented-out and not needed anymore and comments. I should:jsx files
Tasks
Component.jsx
ContrastChecker using
PascalCase`.css
filescss
files and apply class selectors whenever possiblejsx
files deleting comments, clogs, commented-out code