StephMode / recap-project-4-theme-creator

Recap project 4 of nf web dev bootcamp to apply what I've learned about React, JS, Project Management, GitHub
https://recap-project-4-theme-creator-murex.vercel.app
0 stars 0 forks source link

#15 css & jsx standardization and cleanup #21

Closed StephMode closed 1 week ago

StephMode commented 1 week ago

Overview

There are inconsistencies regarding naming of the files:

Bildschirmfoto 2024-11-02 um 15 22 08

There are empty css files which need to be deleted, such as ColorEditor.css.

There are inconsistencies in the css. 🟢 Sometimes I use class selectors, like in ColorForm.css 🔴 Sometimes I use type selectors, like in ContrastChecker.css => I should use class selectors everywhere.

Several .jsx files contain unneccesary logs, code that's commented-out and not needed anymore and comments. I should:

Tasks

StephMode commented 1 week ago

Pivot on Standardize naming of Component.jsx

There is no fixed spec for naming .jsx files as React is unopinionated on this. See: https://stackoverflow.com/questions/43973199/file-naming-conventions-in-reactjs.

I'll stick with PascalCase for naming of my Component.jsx files. Instead, I'll rename the ContrastCheckerfile.

StephMode commented 1 week ago

Pivot on Standardize naming of Component.jsx

There is no fixed spec for naming .jsx files as React is unopinionated on this. See: https://stackoverflow.com/questions/43973199/file-naming-conventions-in-reactjs.

I'll stick with PascalCase for naming of my Component.jsx files. Instead, I'll rename the ContrastCheckerfile.

Accidentially commited it to main. Will open refactor branch now.

StephMode commented 1 week ago

decided to leave the following comps as they are for now: CopyTo: comments are hints for improvements and refactoring. They are useful and shall remain. ColorInput: Have to work on it for a bug fix anyway, so leave it as it is for now