search

Stephan3 / dwc2-for-klipper

A translator between DWC2 and Klipper
GNU General Public License v3.0
160 stars 38 forks source link

add midprint_allow commands and fix multithreading issue #15

Closed rafaljot closed 5 years ago

rafaljot commented 5 years ago
  1. add some extra commands https://github.com/KevinOConnor/klipper/blob/master/docs/G-Codes.md
  2. resolve multithreading issue
  3. resolve issue with response after "m117 abcd" command
Stephan3 commented 5 years ago

Thanks for working the issue with the tornado thread out! That’s a good pointer.

Unfortunately I won’t merge this pull request. Why will one make a tmc_init or a force_move during printing?

Seriously, this filter is there ecxactly to prevent those actions during print. There are useful things there is n your extended list. But with things like set tmc fields during printing, the code provokes burning anets.

Adjusting baby steps is more efficient if you use the buttons on status tab btw. It sets the values imidiatly instead of getting a place in queue. (Which is quiet long during sdprint)

rafaljot commented 5 years ago

ok, I understand your point of view. I removed that change. Let's move this discussion to @danielfmo 's pull request https://github.com/Stephan3/dwc2-for-klipper/pull/12

Stephan3 commented 5 years ago

I picked the threading thing up here.