search

Stephan3 / dwc2-for-klipper

A translator between DWC2 and Klipper
GNU General Public License v3.0
160 stars 38 forks source link

Renames try_load_module to load_object because api change #79

Closed netonjm closed 4 years ago

netonjm commented 4 years ago

Fixes API break in printer.try_load_module

https://github.com/KevinOConnor/klipper/commit/787ed452c2abe3bad81ffaf732b0b2609e3534bb

now webserver intializes again.

IMAGE 2020-05-16 14:34:47

Fixes https://github.com/Stephan3/dwc2-for-klipper/issues/73

Kszajga commented 4 years ago

I did the same in local, it is working perfectly for me.

netonjm commented 4 years ago

@Stephan3 thoughs?

Tomblarom commented 4 years ago

Thanks! I can confirm that this PR fixes the 'try_load_module' Error with the latest DWC2 version!

NedalLive commented 4 years ago

Thanks for the fix! it would be cool to apply it to make it easier!

Stephan3 commented 4 years ago

i picked that one up to a single commit. Thanks for orking that out @netonjm

netonjm commented 4 years ago

It was on a single commit without conflicts, sad because it was not merged 😿

Stephan3 commented 4 years ago

@netonjm dont get me wrong. You had the right idea.

I decided to use lookup_object instead. If needed it fails gently. https://github.com/Stephan3/dwc2-for-klipper/blob/5953e779e5cc2f226e3daabf835a6477ecd49974/web_dwc2.py#L48