search

StephanJoubert / home_assistant_solarman

Home Assistant component for Solarman collectors used with a variety of inverters.
Apache License 2.0
512 stars 191 forks source link

Pysolarmanv5 improvements #375

Closed jmccrohan closed 10 months ago

jmccrohan commented 10 months ago

Hi @StephanJoubert,

As requested, I've reviewed and added a number of fixes to improve the addition of pysolarmanv5 to the Solarman integration.

Note that @cosote had already started to work on this in their fork, so to credit them and avoid duplication, I've based these fixes upon theirs.

Cheers, Jon

maslyankov commented 10 months ago

@StephanJoubert Maybe merge this, seems like there are plenty of improvements?

StephanJoubert commented 10 months ago

Thanks @jmccrohan much appreciated.