search

StephanTLavavej / mingw-distro

MinGW distro build scripts.
494 stars 55 forks source link

make.patch silences a warning that should be fixed upstream #5

Closed StephanTLavavej closed 8 years ago

StephanTLavavej commented 8 years ago

make.patch silences a warning that appeared in GCC 5.1.0 with -Wall -Wextra -Werror. I looked at what the code was doing, concluded that it was correct, and that adding extra parentheses silenced the warning without changing the meaning of the code.

This patch should be committed upstream. make's maintainers might notice this when they start using GCC 5.1.0 or newer, but they might not.

StephanTLavavej commented 8 years ago

Instead of patching, I should just build with -Wno-logical-not-parentheses .

StephanTLavavej commented 8 years ago

Fixed by d22688b. Now, I just build make without warnings, which is what I do for all other direct gcc invocations.