search

Stephane-D / SGDK

SGDK - A free and open development kit for the Sega Mega Drive
https://www.patreon.com/SGDK
MIT License
1.75k stars 187 forks source link

XGM Driver Bug (com_pcm_p1_ch1 -> JP com_pcm_ch0) #167

Closed hsk closed 4 years ago

hsk commented 4 years ago

I found bug on xgm driver when I read source code. https://github.com/Stephane-D/SGDK/blob/master/src/z80_xgm.s80#L2068

This line is com_pcm_p1_ch1 -> JP com_pcm_ch0. But I think com_pcm_p1_ch1 -> JP com_pcm_ch1.

Stephane-D commented 4 years ago

Oh nice catch ! Indeed a stupid copy/paste typo. Thanks for reveling it (i just fixed it) :)

hsk commented 4 years ago

Thank you very much. :)