search

Stephane-D / SGDK

SGDK - A free and open development kit for the Sega Mega Drive
https://www.patreon.com/SGDK
MIT License
1.7k stars 179 forks source link

add multi-platform docker image #292

Open justgook opened 11 months ago

justgook commented 11 months ago

Resolves #290

joeyparrish commented 4 months ago

Wow, I really like this. I can't speak for the maintainers, but I plan to use it myself.

One bit of feedback: The GitHub diff shows a bunch of files where almost everything is changed, but I suspect what's happening is that some newlines got switched from DOS to Unix style. As much as I appreciate that change and generally prefer to see Unix newlines in things, if you can avoid changing newline styles and making functional changes in the same PR, it would make the diffs easier to read, review, and understand.

joeyparrish commented 4 months ago

This has merge conflicts with the latest master branch. I am not a maintainer here, so I don't have rights to push to the fork of @justgook, but I will upload a rebased and cleaned up PR (no newline changes) from my own fork that maintains his name and email as the author of the commit. @justgook, if you object, or would like to incorporate my edits yourself, I would be happy to send my changes to you instead.

Thanks again, @justgook for redoing the Docker images in the first place, and @Stephane-D for the incredible SGDK!

justgook commented 4 months ago

@joeyparrish im happy, if you can continue on it.. i kid if switched to other projects.. and have no time for now to do those fine tuning..

joeyparrish commented 4 months ago

@justgook, I am unable to make the multi-platform builds work in CI. The emulated arm64 build of GCC keeps hanging in GitHub's VMs. So my version will now have two commented-out sections in the workflow to re-enable arm64 at a later date. The rest seems to work, though.

I went through the actions runs on your fork to see if this was a bug I introduced somehow, but I didn't see any successful runs of the GCC build there. Happy to have your input if you have any, but otherwise, I'm going to push forward with a single-platform workflow for now.

justgook commented 4 months ago

as i remember it took few hours to build arm64 version of gcc on CI. and it will be like that until github will get native arm64 runners. I had success of building, but don’t remember how. as later i switched my focus to building all tools as part of pipeline, that builds all those tools using makefiles without docker.