search

Stephanevg / PSClassUtils

A set of utilities to work with Powershell Classes
http://powershelldistrict.com/how-to-generate-a-uml-diagram-using-powershell/
93 stars 23 forks source link

Bug Fix in out-cupsgraph + rewrite of write-cuclassdiagram #70

Closed LxLeChat closed 5 years ago

LxLeChat commented 5 years ago

write-cuclassdiagram has a new parameter outputdiagram (doesnt mind if we change it's name...) to determine if the output file are file(s) based, or directory based. (it's actuallay a complete rewrite.. issue:#69) also remvoed the pre-check for psgraph... maybe we need an issue on that, and do the work somewhere else (psm1 or psd1 dunno !)

Bug fix in out-cupsgraph: when a property was referenced in an other class, and the property was an array, the composistion did not work. Problem fixed with a regex replace... i alsod added some verbose output... helped me solve the stuff... !

Stephanevg commented 5 years ago

Hi @LxLeChat , Awesome, thank you so much for your PR!! I looked into the failing tests, and according to them, the -Passthru parameter doesn't seem to work anymore. image

It would be really awesome if you could fix them, to ensure that the functionality we deliver has not been impacted by the rewrite of the cmdlet.

LxLeChat commented 5 years ago

my bad! i forgot -passthru

LxLeChat commented 5 years ago

for the PR i m not satisfied with my code :) i'll be back with something better !! the out-cupsgraph fix is still valid !