Stephanevg / PSHTML

Cross platform Powershell module to generate HTML markup language
https://pshtml.readthedocs.io/en/latest/
Other
167 stars 43 forks source link

New $htmltagparams + fix content #111

Closed christophekumor closed 6 years ago

christophekumor commented 6 years ago

Please fill in all placeholders --> [Placeholder]

Pull Request [Topic]

Modified the way htmltagparams variable is filling. With this new method, we are sure to have all parameters passed to the function AND defaults parameters (the ones not passed to function)

Please tell us , the type of Change you are submiting:

Select one of the following:

Does it fix an existing issue? Please tell us which one

Resolves #108 Fixes #61 Resolves #50

Description of what's been changed

Results of your tests (If applicable)

Stephanevg commented 6 years ago

Salut @christophekumor Super merci pour ton PR. J'ai hate de le merger. Mais avant de proceder, j'aurais bien voulu avec l'update du test pester qui va avec.

Il me semble que tu avais rajouter un test pester aussi pour tester ce cas précis non? Pourrais-tu le rajouter à ce PR? 👍

Merci

christophekumor commented 6 years ago

salut @Stephanevg Oui mes ajouts Pester sont dans la branche Pester pour laquelle tu as un autre PR

Stephanevg commented 6 years ago

ok super! Merci pour ton PR @christophekumor