search

Stephanevg / PSHTML

Cross platform Powershell module to generate HTML markup language
https://pshtml.readthedocs.io/en/latest/
Other
165 stars 43 forks source link

Feature get pshtml color #241

Closed wightsci closed 5 years ago

wightsci commented 5 years ago

Addresses issue #226

A fairly major overhaul to the Color class, setting up a generic way of dealing with colors and adding the ability to output them in hex "#FFFFFF" format. The class has got support for the 140+ W3 color names (instead of those originally part of the module) but it does add 290+ lines to the module.

I've also created a Get-PSTMLColor function that generates rgb, rgba, hsl, hsla or hex format values based on a color name.

Stephanevg commented 5 years ago

Hi, @wightsci I am really looking forward to merge this one!!

Would you mind switching the PR to the dev branch? Thanks! :)

Stephanevg commented 5 years ago

Awwwesome!! 🎈 🎉 🌈

Thanky you SO much 🙏 for your PR. You have no idea what it means to me, plus, this is a feature I wanted to implement since a long time, but simply never got it. Thanks again! 👍 👍 🙏

I'll merge it right away. There are a few small thinigies I needd / need to do, but I'll do it on my side, since it is the small little things of maintaining an open source module ;)

I have written below some notes on the PR, for next time ;)

Thank you again for your outstanding work ! 🙏

some notes on the PR it self

There was a merge conflict, which I actually wrongly fixed, which is why all the builds are failing.

Your tests passed successfully:

image

The tests failing, is because somehow, the 'I' cmdlets got removed from the ExportedFunctions.It is not that much to fix, and i'll do it on my end.

In the futur, this could be avoided if you write your code in a sepeare file located in Code\Functions\public

And call the CI\03_Build.ps1 script to generate the module manifest. It will do all the heavy lifting for you ;)

Also, try to to do a Pull before the PR, It get's pretty busy on the dev branch, and yours was a bit out of date.

Stephanevg commented 5 years ago

@wightsci A last remark, I opened this issue https://github.com/Stephanevg/PSHTML/issues/245 to as I noticed you wrote everything in the PSM1 directly.

This is actually not a problem, but to ease the developement process, I generally have the functions and classes stored in seperate files. In this particular case, it would make sense to keep the class and the function in the same file. If you feel like going ahead, and finish that issue, be my gues ;)

Stephanevg commented 5 years ago

Also, last question (I swear!) do you use PSHTML your self? if so, I would be curious to discuss your use cases with you.