Closed Stephanevg closed 5 years ago
I have an update that will provide this, but I see that my previous PR has problems...
Hi @wightsci that would be really great!
I actually commented the PR, and I think you can simply cancel your PR that externalized the function / class in seperate files as I ended up doing it my self since I was working on it yesterday.
You can actually add the argument completer directly in the class (It is located in Code\Classes\003.pshtml.components.charts.ps1
) and send another PR
I've closed the PR. I have 2 commits:
Add the list of colours as a static member to the [Color] class. Add the ArgumentCompleter to the function.
Is that OK, or do you prefer me to do it all in one step in the function?
@wightsci It actually doesn't matter, as github will show the two different commits in one single PR (thus one single modification). So, 2 commits should be just fine :)
Just merge the PR -> https://github.com/Stephanevg/PSHTML/pull/249/ Super outstanding work that you have done @wightsci I am looking forward to your next contribution ! ;) (Let me know if you are interested)
Currently, when a user want to get a color, it will -Color, but he need to 'know in advance' the colors that exists.
It would be nice to either, add all the possible values to a ValidateSet OR perhaps listing all the available colros in an Enum called PSHTMLCOLOR, and change the -Color type from [String] to [PSHTMLCOLOR]
Color listing
for reference, all the current support colors