search

Stephanevg / PSHTML

Cross platform Powershell module to generate HTML markup language
https://pshtml.readthedocs.io/en/latest/
Other
165 stars 43 forks source link

Externalised Color class and Get-PSHTML function as per #246 #247

Closed wightsci closed 5 years ago

wightsci commented 5 years ago

Pull Request as per #246

Commented out old [Color] class. Created Get-PSHTMLColor.ps1 containing class and function. Ran rebuild script.

Stephanevg commented 5 years ago

Hi @wightsci

Thank you so much for your PR. Actually, I was working on PSHTML yesterday night, and I almost lost your code when rebuilding the module ( I actually forgot it was not in a seperate file), so I went ahead and decoupled the things.

Your code is now in the right place (in seperate files etc..) the only thing that is not yet added is the ArgumentCompleter part.

Fixing the conflicts on my side on github, is a bit cumbersome. Plus, I think that it would be way faster if you switch on your local dev branch, do a git pull upstream, and add the argument completer there in Code\Functions\Get-PSHTMLColor.ps1 and push that as a PR.

You think that would be possible?