search

Stephcraft / Project-16x16

2D Platformer game made with processing
GNU General Public License v3.0
97 stars 77 forks source link

Rename SideScroller.java to Main.java, Fix warnings #135

Closed JacksonHoggard closed 4 years ago

JacksonHoggard commented 4 years ago

134 Fixed warnings

133 Renamed SideScroller.java to Main.java

Stephcraft commented 4 years ago

Nice stuff! But the warning fixing introduced a bug: when clicking in play mode, the game crashes. Here are the logs:

java.util.ConcurrentModificationException
    at java.util.ArrayList$Itr.checkForComodification(Unknown Source)
    at java.util.ArrayList$Itr.next(Unknown Source)
    at project_16x16.entities.Player.handleMouseInput(Player.java:233)
    at project_16x16.entities.Player.update(Player.java:152)
    at project_16x16.scene.GameplayScene.drawPlayer(GameplayScene.java:258)
    at project_16x16.scene.GameplayScene.draw(GameplayScene.java:231)
    at project_16x16.Main.drawBelowCamera(Main.java:292)
    at project_16x16.Main.draw(Main.java:269)
    at processing.core.PApplet.handleDraw(PApplet.java:2437)
    at processing.javafx.PSurfaceFX$1.handle(PSurfaceFX.java:89)
    at processing.javafx.PSurfaceFX$1.handle(PSurfaceFX.java:1)
    at com.sun.scenario.animation.shared.TimelineClipCore.visitKeyFrame(TimelineClipCore.java:239)
    at com.sun.scenario.animation.shared.TimelineClipCore.playTo(TimelineClipCore.java:197)
    at javafx.animation.Timeline.impl_playTo(Timeline.java:176)
    at javafx.animation.AnimationAccessorImpl.playTo(AnimationAccessorImpl.java:39)
    at com.sun.scenario.animation.shared.InfiniteClipEnvelope.timePulse(InfiniteClipEnvelope.java:126)
    at javafx.animation.Animation.impl_timePulse(Animation.java:1102)
    at javafx.animation.Animation$1.lambda$timePulse$0(Animation.java:186)
    at java.security.AccessController.doPrivileged(Native Method)
    at javafx.animation.Animation$1.timePulse(Animation.java:185)
    at com.sun.scenario.animation.AbstractMasterTimer.timePulseImpl(AbstractMasterTimer.java:344)
    at com.sun.scenario.animation.AbstractMasterTimer$MainLoop.run(AbstractMasterTimer.java:267)
    at com.sun.javafx.tk.quantum.QuantumToolkit.pulse(QuantumToolkit.java:557)
    at com.sun.javafx.tk.quantum.QuantumToolkit.pulse(QuantumToolkit.java:541)
    at com.sun.javafx.tk.quantum.QuantumToolkit.pulseFromQueue(QuantumToolkit.java:534)
    at com.sun.javafx.tk.quantum.QuantumToolkit.lambda$runToolkit$11(QuantumToolkit.java:340)
    at com.sun.glass.ui.InvokeLaterDispatcher$Future.run(InvokeLaterDispatcher.java:95)
    at com.sun.glass.ui.win.WinApplication._runLoop(Native Method)
    at com.sun.glass.ui.win.WinApplication.lambda$null$3(WinApplication.java:177)
    at java.lang.Thread.run(Unknown Source)
JacksonHoggard commented 4 years ago

I've committed the changes mentioned above. Let me know if there are any other issues!

micycle1 commented 4 years ago

Let me know if there are any other issues!

Haven't reverted the switch case --> if changes you made.

Stephcraft commented 4 years ago

I am still getting 64 warnings, but most of them are "API restriction":

image

Here are the other warnings I am getting: image