search

Stephen-McDaniel / r-google-analytics

This repository is an export of the final version from the retired Google Code system (code.google.com/p/r-google-analytics).
0 stars 0 forks source link

Handle spaces in query builder input #2

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
This isn't a bug, but I'm stumped on real contact info for any of the 
maintainers.

I tweaked QueryBuilder() so that it's a little friendlier in accepting user 
input -- if you accidentally include a space after the comma in specifying 
dimensions, for example, I don't think you should get a 400 Bad Request back - 
instead, should just strip spaces from the URL - there's no good reason for 
them to be there.

Anyways, I made this change, and since I couldn't find any better way than this 
to submit suggested changes, I created a git repo. You can see the changes at 
https://github.com/noahhl/r-google-analytics. I may make further tweaks to make 
this more user friendly and push to that repo. I'm happy to commit here as well 
(though I vastly prefer github).

Original issue reported on code.google.com by lor...@gmail.com on 25 Feb 2011 at 5:59

GoogleCodeExporter commented 9 years ago 
I will add this fix into the latest version.
Thanks

Original comment by michael....@gmail.com on 17 Feb 2013 at 11:07

GoogleCodeExporter commented 9 years ago 
Now fixed in new version

Original comment by michael....@gmail.com on 24 Feb 2013 at 9:10