Stephen-McDaniel / rpostgresql

This repository is an export of the final version from the retired Google Code system (code.google.com/p/rpostgresql).
0 stars 0 forks source link

dbRemoveTable #23

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. create a table containing capital letter like Foo2
2. call dbRemoveTable(con, "Foo2")
3. check if it is really removed with psql or
dbExistsTable(con, "Foo2")

What is the expected output? What do you see instead?

Expects the table being removed. Actually fails to do so.
Its also dangerous because it can infact delete lowercase letter
named table if exists.

What version of the product are you using? On what operating system?
RPostgreSQL_0.1-6 plus some patches
R-2.11.1 
Posgresql-8.4.4

Please provide any additional information below.

Test code and patch is attached.

Output after patch:

==== Running RPostgreSQL/tests/dbRemoveTableTest.R
Loading required package: RPostgreSQL
Loading required package: DBI

Create foo1 table
Pass - foo1 Table exists. created
removing foo1
Pass - foo1 Table does not exist. i.e. deleted

Create Foo2 table
Pass - Foo2 Table exists. created
removing Foo2
Pass - Foo2 Table does not exist. i.e. deleted

Create Fo"o3 table
Pass - Fo"o3 Table exists. created
removing Fo"o3
Pass - Fo"o3 Table does not exist. i.e. deleted
[1] TRUE

Original issue reported on code.google.com by tomoa...@kenroku.kanazawa-u.ac.jp on 12 Sep 2010 at 2:13

Attachments:

GoogleCodeExporter commented 9 years ago
Reassigned.

Original comment by ne...@neiltiffin.com on 13 Oct 2010 at 12:53

GoogleCodeExporter commented 9 years ago
Fixed with r152 (code), r155 (doc).

Original comment by tomoa...@kenroku.kanazawa-u.ac.jp on 13 Oct 2010 at 2:53