StephenBarnes / Canals-V1-abandoned

Abandoned in favor of rewrite: https://github.com/StephenBarnes/Canals-V2
Other
0 stars 0 forks source link

Incompatibility with RoadRunner #1

Open Drakoflame opened 2 years ago

Drakoflame commented 2 years ago

Hello! I spent a good 3 hours (when I could have done it in 30 minutes... note to self, A-Z, not Z-A....) trying to figure out what was causing a crash with the performance mod, Road Runner (Labled "Meep Meep" in the crash report). I know this mod is heavily WIP, so I hope that this report might be able to assist with further development of the mod.

I really hope that the two don't end up incompatible, because I miss the old Better Than Wolves/Better With Mods fluid canals for transporting water, but until then I'll make due with your "Create Irrigation" mod to water my plants!

Versions Used: Forge 36.2.2 Canals 1.0a RoadRunner 1.2.2

malte0811 commented 2 years ago

Chiming in as one of the RoadRunner devs:
Bug report on our end: MaxNeedsSnacks/roadrunner#11 (with crash reports)
I haven't been able to reproduce the crash from our issue, and I have no idea how it would happen (some race in Forge's concurrent loading code?). I do have a different startup crash though: RR precomputes the FluidState for all BlockStates. Here LEVEL is from 1-15 for the block state, while the fluid state needs a level from 1-8.

StephenBarnes commented 2 years ago

Thanks for letting me know, and sorry for taking your time. I'll fix that specific startup crash, and add a note to the CurseForge page. On the whole I think the approach I used for this mod is going to be unstable and incompatible with lots of mods. I'm working on implementing a better approach that shouldn't have compatibility issues.