StephenBlackWasAlreadyTaken / NightWatch

A native android Nightscout client with alerts and google wear integration
GNU General Public License v3.0
92 stars 167 forks source link

Time duration sliders not working #111

Open thanksegon opened 6 years ago

thanksegon commented 6 years ago

Using latest apk I am unable to select a snooze time other than default. I click other times/choices but they are not saved or recognized. For example, the default snooze for a High is 2 hours; I'd rather set it to 1 hour. I choose 60 minutes in the slider but it is not accepted. Only Cancel is recognized. The snooze stays set to the default of 2 hours.

GHNS commented 6 years ago

Do you mean the snooze-timespan which is shown below the snooze-button or the dialog that pops-up when you tap on "disable XXX alterts"?

I think for the first you have to select the time being used when you press the "snooze" button (which seems to work, if I select 10 minutes as snooze time and click on snooze, it tells me the current alert is snoozed until now+10mins).

For the latter (dialog for choosing time to disable alerts) there is an issue that prevents the "set" button from being shown. I have fixed the issue on my device by recompiling the project with a changed /mobile/src/main/res/layout/snooze_picker.xml file (I changed layout_width and layout_height values):

<?xml version="1.0" encoding="utf-8"?>
<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
    android:orientation="vertical" android:layout_width="fill_parent"
    android:layout_height="fill_parent">

    <LinearLayout
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
        android:layout_gravity="center"
        android:orientation="vertical"
        android:gravity="center_horizontal">

        <NumberPicker
                android:id="@+id/numberPicker1"
                android:layout_width="fill_parent"
                android:layout_height="fill_parent"
                android:layout_alignParentTop="true"
                android:layout_centerHorizontal="true"/>

        <LinearLayout
            android:orientation="horizontal"
            android:layout_width="wrap_content"
            android:layout_height="wrap_content"
            android:layout_gravity="center_horizontal"
            android:gravity="center_horizontal">

            <Button
                    android:id="@+id/button2"
                    android:layout_width="wrap_content"
                    android:layout_height="wrap_content"
                    android:text="Cancel" />

            <Button
                    android:id="@+id/button1"
                    android:layout_width="wrap_content"
                    android:layout_height="wrap_content"
                    android:text="Set" />
        </LinearLayout>
    </LinearLayout>

</LinearLayout>

screenshot

thanksegon commented 6 years ago

Hi, I've attached a screenshot. I want to change this to 15 minutes, for example. I click on the 15 minutes and nothing happens. There isn't a readily apparent way to select 15 minutes and the save the alert.

Joe Ritson Simpletonia LLC Office Phone: 617.595.4900

Cell Phone: 617.775.7750

LinkedIn: www.linkedin.com/in/josephritsonhttp://www.linkedin.com/in/josephritson


From: GHNS notifications@github.com Sent: Monday, July 2, 2018 2:15 PM To: StephenBlackWasAlreadyTaken/NightWatch Cc: thanksegon; Author Subject: Re: [StephenBlackWasAlreadyTaken/NightWatch] Time duration sliders not working (#111)

Do you mean the snooze-timespan which is shown below the snooze-button or the dialog that pops-up when you tap on "disable XXX alterts"?

I think for the first you have to select the time being used when you press the "snooze" button (which seems to work, if I select 10 minutes as snooze time and click on snooze, it tells me the current alert is snoozed until now+10mins).

For the latter (dialog for choosing time to disable alerts) there is an issue that prevents the "set" button from being shown. I have fixed the issue on my device by recompiling the project with a changed /mobile/src/main/res/layout/snooze_picker.xml file (I changed layout_width and layout_height values):

<?xml version="1.0" encoding="utf-8"?> <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android" android:orientation="vertical" android:layout_width="fill_parent" android:layout_height="fill_parent">

<LinearLayout
    android:layout_width="wrap_content"
    android:layout_height="wrap_content"
    android:layout_gravity="center"
    android:orientation="vertical"
    android:gravity="center_horizontal">

    <NumberPicker
            android:id="@+id/numberPicker1"
            android:layout_width="fill_parent"
            android:layout_height="fill_parent"
            android:layout_alignParentTop="true"
            android:layout_centerHorizontal="true"/>

    <LinearLayout
        android:orientation="horizontal"
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
        android:layout_gravity="center_horizontal"
        android:gravity="center_horizontal">

        <Button
                android:id="@+id/button2"
                android:layout_width="wrap_content"
                android:layout_height="wrap_content"
                android:text="Cancel" />

        <Button
                android:id="@+id/button1"
                android:layout_width="wrap_content"
                android:layout_height="wrap_content"
                android:text="Set" />
    </LinearLayout>
</LinearLayout>

[screenshot]https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fuser-images.githubusercontent.com%2F40469911%2F42179520-96536c58-7e34-11e8-8c14-34174e668aed.png&data=02%7C01%7C%7C20a20c8c55bb4a12239d08d5e047c2c0%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636661521164166451&sdata=qn8zhJm%2F36OhT8oA7sicqdsfR8tuq3N8TPjeLDvdJL8%3D&reserved=0

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FStephenBlackWasAlreadyTaken%2FNightWatch%2Fissues%2F111%23issuecomment-401889692&data=02%7C01%7C%7C20a20c8c55bb4a12239d08d5e047c2c0%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636661521164166451&sdata=r5203QdIG75%2BOGPwKEfyc71EpBtYgPti0IVAFiflQks%3D&reserved=0, or mute the threadhttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAVZP4Opl-Ts2hV2egTPEUSiO-LhFS8P-ks5uCmMygaJpZM4U-MLX&data=02%7C01%7C%7C20a20c8c55bb4a12239d08d5e047c2c0%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636661521164166451&sdata=WRwGumC7oQUa9WRhGLEDtMszD6s8WO4HKMAz%2F%2B2Cz0I%3D&reserved=0.

thanksegon commented 5 years ago

Just curious if NW is an active project? Will there be updates and fixes, or have resources moved to another project?

Wanitta commented 5 years ago

I used Nightwatch for awhile. With the newer versions of xDrip+, I found I didn't need it. Xdrip+ App will connect directly to various Android wear watches and can be set up with a follower. Check out xDrip group on Facebook.

Wanitta

Sent from my Verizon, Samsung Galaxy smartphone

-------- Original message -------- From: thanksegon notifications@github.com Date: 9/18/18 10:52 PM (GMT-06:00) To: StephenBlackWasAlreadyTaken/NightWatch NightWatch@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: Re: [StephenBlackWasAlreadyTaken/NightWatch] Time duration sliders not working (#111)

Just curious if NW is an active project? Will there be updates and fixes, or have resources moved to another project?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/StephenBlackWasAlreadyTaken/NightWatch/issues/111#issuecomment-422641737, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ADS1fA0wMgc8ZBULalX8fics1lBpLrx8ks5ucb9ugaJpZM4U-MLX.

thanksegon commented 5 years ago

Thanks. I’m using xDrip-jswhich runs on my rig, so there isn’t an app per se. Watch is the only Android app someone can use to follow me, I think.

Joe Ritson Cell Phone: 617.775.7750 LinkedIn: www.linkedin.com/in/josephritsonhttp://www.linkedin.com/in/josephritson

From: Wanitta [mailto:notifications@github.com] Sent: Wednesday, September 19, 2018 6:56 AM To: StephenBlackWasAlreadyTaken/NightWatch NightWatch@noreply.github.com Cc: thanksegon josephritson@outlook.com; Author author@noreply.github.com Subject: Re: [StephenBlackWasAlreadyTaken/NightWatch] Time duration sliders not working (#111)

I used Nightwatch for awhile. With the newer versions of xDrip+, I found I didn't need it. Xdrip+ App will connect directly to various Android wear watches and can be set up with a follower. Check out xDrip group on Facebook.

Wanitta

Sent from my Verizon, Samsung Galaxy smartphone

-------- Original message -------- From: thanksegon notifications@github.com<mailto:notifications@github.com> Date: 9/18/18 10:52 PM (GMT-06:00) To: StephenBlackWasAlreadyTaken/NightWatch NightWatch@noreply.github.com<mailto:NightWatch@noreply.github.com> Cc: Subscribed subscribed@noreply.github.com<mailto:subscribed@noreply.github.com> Subject: Re: [StephenBlackWasAlreadyTaken/NightWatch] Time duration sliders not working (#111)

Just curious if NW is an active project? Will there be updates and fixes, or have resources moved to another project?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/StephenBlackWasAlreadyTaken/NightWatch/issues/111#issuecomment-422641737, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ADS1fA0wMgc8ZBULalX8fics1lBpLrx8ks5ucb9ugaJpZM4U-MLX.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FStephenBlackWasAlreadyTaken%2FNightWatch%2Fissues%2F111%23issuecomment-422755664&data=02%7C01%7C%7Ca9712e5f18c442db3d8f08d61e1e7aec%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636729513584105172&sdata=GmpSMxj07X6ETHrwg9CMrkHrWXNrefJ6xuNnstHE4Wc%3D&reserved=0, or mute the threadhttps://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAVZP4FCLGN1K0ZBwuYEuJjwgFxSDtaL_ks5uciK9gaJpZM4U-MLX&data=02%7C01%7C%7Ca9712e5f18c442db3d8f08d61e1e7aec%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636729513584115176&sdata=3IVx0O%2FnKW4k%2FdS%2BmRjb7F2PS8407SZMBQvMcDb%2BUSc%3D&reserved=0.

Wanitta commented 5 years ago

You can put xDrip+ app on both phones and set one up as Master and the other as Follower. I gave you the info on where to look for more info.

Wanitta

Sent from my Verizon, Samsung Galaxy smartphone

-------- Original message -------- From: thanksegon notifications@github.com Date: 9/19/18 1:34 PM (GMT-06:00) To: StephenBlackWasAlreadyTaken/NightWatch NightWatch@noreply.github.com Cc: Wanitta wanitta@live.com, Comment comment@noreply.github.com Subject: Re: [StephenBlackWasAlreadyTaken/NightWatch] Time duration sliders not working (#111)

Thanks. I’m using xDrip-jswhich runs on my rig, so there isn’t an app per se. Watch is the only Android app someone can use to follow me, I think.

Joe Ritson Cell Phone: 617.775.7750 LinkedIn: www.linkedin.com/in/josephritsonhttp://www.linkedin.com/in/josephritson

From: Wanitta [mailto:notifications@github.com] Sent: Wednesday, September 19, 2018 6:56 AM To: StephenBlackWasAlreadyTaken/NightWatch NightWatch@noreply.github.com Cc: thanksegon josephritson@outlook.com; Author author@noreply.github.com Subject: Re: [StephenBlackWasAlreadyTaken/NightWatch] Time duration sliders not working (#111)

I used Nightwatch for awhile. With the newer versions of xDrip+, I found I didn't need it. Xdrip+ App will connect directly to various Android wear watches and can be set up with a follower. Check out xDrip group on Facebook.

Wanitta

Sent from my Verizon, Samsung Galaxy smartphone

-------- Original message -------- From: thanksegon notifications@github.com<mailto:notifications@github.com> Date: 9/18/18 10:52 PM (GMT-06:00) To: StephenBlackWasAlreadyTaken/NightWatch NightWatch@noreply.github.com<mailto:NightWatch@noreply.github.com> Cc: Subscribed subscribed@noreply.github.com<mailto:subscribed@noreply.github.com> Subject: Re: [StephenBlackWasAlreadyTaken/NightWatch] Time duration sliders not working (#111)

Just curious if NW is an active project? Will there be updates and fixes, or have resources moved to another project?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/StephenBlackWasAlreadyTaken/NightWatch/issues/111#issuecomment-422641737, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ADS1fA0wMgc8ZBULalX8fics1lBpLrx8ks5ucb9ugaJpZM4U-MLX.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FStephenBlackWasAlreadyTaken%2FNightWatch%2Fissues%2F111%23issuecomment-422755664&data=02%7C01%7C%7Ca9712e5f18c442db3d8f08d61e1e7aec%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636729513584105172&sdata=GmpSMxj07X6ETHrwg9CMrkHrWXNrefJ6xuNnstHE4Wc%3D&reserved=0, or mute the threadhttps://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAVZP4FCLGN1K0ZBwuYEuJjwgFxSDtaL_ks5uciK9gaJpZM4U-MLX&data=02%7C01%7C%7Ca9712e5f18c442db3d8f08d61e1e7aec%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636729513584115176&sdata=3IVx0O%2FnKW4k%2FdS%2BmRjb7F2PS8407SZMBQvMcDb%2BUSc%3D&reserved=0.

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/StephenBlackWasAlreadyTaken/NightWatch/issues/111#issuecomment-422911652, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ADS1fF5oLj9nZgGdJ0RwfPLF3COALZoKks5uco4qgaJpZM4U-MLX.

thanksegon commented 5 years ago

GHNS I'm not a developer, but it sounds as I should download the source, modify the snooze_picker.xlm and then compile a new apk? Is that what you're suggesting I do?

GHNS commented 5 years ago

GHNS I'm not a developer, but it sounds as I should download the source, modify the snooze_picker.xlm and then compile a new apk? Is that what you're suggesting I do?

Yes, that's true. I downloaded the studio3 branch so I could open it in Android Studio 3. Then, I edited the snooze_picker.xlm file from within Android Studio (you can see the effect of changes on the preview panel immediately) and built a signed APK. You need to create a new Key store for doing so. Once you have built the APK, you need to uninstall NightWatch from your mobile (write your app settings down before) and then install your own APK (because you cannot in-place update the app using your own key).

Good luck!