StephenBlackWasAlreadyTaken / xDrip-Experimental

Experimental Branches for Collaboration on DexDrip
GNU General Public License v3.0
25 stars 62 forks source link

colors in xDrip notification / background #343

Open fezulin opened 8 years ago

fezulin commented 8 years ago

Hi all! Every 5 minutes the xDrip-App receives a measurement from the xDrip. Each measurement is displayed as a point in a graph. The color of the points depend on the value: (Beta5 v2.0.5_2 update 2)

In discussions with Adrian I learned, that it might be planned to change these colors, to have the same colors as used in Nightscount.

So far: Fully agreement. That is a good intention.

But a problem occurs in case of the background color differs from black. I observed with Android 5.1, that the color of the background in the notification is by default white. And that I cannot change this color manually on my device. (At least: I have no idea how this can be done.)

The yellow points are difficult to recognize on the white background. notification_white

It would be very comfortable, if the background color was defined as black: notification_black

If there is a choice, the background color of the Widget should not be influenced by this change.

AdrianLxM commented 8 years ago

@fezulin thanks.

It would not be much work to make the chart background black for the Notification and keep it transparent in other cases.

@jstevensog how about your pebble integration. As this would cause merge conflicts (that I cannot test) it would be good to have it in first. Then I could add this without changing the pebble image generation bahaviour.

jstevensog commented 8 years ago

@AdrianLxM, I am still to get the install from the app working. I want to automate it if possible. But the PebbleTrend branch can probably be merged. I will get the latest master over the weekend and get PebbleTrend rebased to it. That should resolve any merge conflicts. The auto install can wait. I can make the PBW available to those wanting to try out the new trend watch face. Won't put it on the pebble store though, that would make the older xDrips look weird. Cheers

On Thu, May 26, 2016 at 8:39 PM, AdrianLxM notifications@github.com wrote:

@fezulin https://github.com/fezulin thanks.

It would not be much work to make the chart background black for the Notification and keep it transparent in other cases.

@jstevensog https://github.com/jstevensog how about your pebble integration. As this would cause merge conflicts (that I cannot test) it would be good to have it in first. Then I could add this without changing the pebble image generation bahaviour.

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/StephenBlackWasAlreadyTaken/xDrip-Experimental/issues/343#issuecomment-221837233

John Stevens "You are how you live, not what you have."

jstevensog commented 8 years ago

OK, I have checked PebbleTrend for merge conflicts with master and there are none with my local branch. I just need to go through the local branch and make sure there is nothing that cannot be pushed up. I don't think there is, but last time I was working on it, I was looking at enhancing the configurability of the watch face, and making the settings be done in the Pebble watch face settings rather than in xDrip. I am fairly sure there is no issue with the code, so if you wanted to merge, you could do so. The watch face included in the branch should work fine. I just cannot test it right now. Cheers

On Fri, May 27, 2016 at 10:17 AM, John Stevens jstevensog@gmail.com wrote:

@AdrianLxM, I am still to get the install from the app working. I want to automate it if possible. But the PebbleTrend branch can probably be merged. I will get the latest master over the weekend and get PebbleTrend rebased to it. That should resolve any merge conflicts. The auto install can wait. I can make the PBW available to those wanting to try out the new trend watch face. Won't put it on the pebble store though, that would make the older xDrips look weird. Cheers

On Thu, May 26, 2016 at 8:39 PM, AdrianLxM notifications@github.com wrote:

@fezulin https://github.com/fezulin thanks.

It would not be much work to make the chart background black for the Notification and keep it transparent in other cases.

@jstevensog https://github.com/jstevensog how about your pebble integration. As this would cause merge conflicts (that I cannot test) it would be good to have it in first. Then I could add this without changing the pebble image generation bahaviour.

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/StephenBlackWasAlreadyTaken/xDrip-Experimental/issues/343#issuecomment-221837233

John Stevens "You are how you live, not what you have."

John Stevens "You are how you live, not what you have."

jstevensog commented 8 years ago

Pushed the latest PebbleTrend. Cheers

On Mon, May 30, 2016 at 7:31 AM, John Stevens jstevensog@gmail.com wrote:

OK, I have checked PebbleTrend for merge conflicts with master and there are none with my local branch. I just need to go through the local branch and make sure there is nothing that cannot be pushed up. I don't think there is, but last time I was working on it, I was looking at enhancing the configurability of the watch face, and making the settings be done in the Pebble watch face settings rather than in xDrip. I am fairly sure there is no issue with the code, so if you wanted to merge, you could do so. The watch face included in the branch should work fine. I just cannot test it right now. Cheers

On Fri, May 27, 2016 at 10:17 AM, John Stevens jstevensog@gmail.com wrote:

@AdrianLxM, I am still to get the install from the app working. I want to automate it if possible. But the PebbleTrend branch can probably be merged. I will get the latest master over the weekend and get PebbleTrend rebased to it. That should resolve any merge conflicts. The auto install can wait. I can make the PBW available to those wanting to try out the new trend watch face. Won't put it on the pebble store though, that would make the older xDrips look weird. Cheers

On Thu, May 26, 2016 at 8:39 PM, AdrianLxM notifications@github.com wrote:

@fezulin https://github.com/fezulin thanks.

It would not be much work to make the chart background black for the Notification and keep it transparent in other cases.

@jstevensog https://github.com/jstevensog how about your pebble integration. As this would cause merge conflicts (that I cannot test) it would be good to have it in first. Then I could add this without changing the pebble image generation bahaviour.

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/StephenBlackWasAlreadyTaken/xDrip-Experimental/issues/343#issuecomment-221837233

John Stevens "You are how you live, not what you have."

John Stevens "You are how you live, not what you have."

John Stevens "You are how you live, not what you have."

danpowell88 commented 8 years ago

I'd like to add that having the green/yellow colors as current on a black background is really difficult to tell the difference to someone like me who is partially colour blind.

screenshot_2016-06-02-21-54-34